From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76234 invoked by alias); 30 Oct 2018 20:22:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76222 invoked by uid 89); 30 Oct 2018 20:22:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Oct 2018 20:22:16 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 505E02D7E2; Tue, 30 Oct 2018 20:22:15 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-116-62.ams2.redhat.com [10.36.116.62]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1155D60CD7; Tue, 30 Oct 2018 20:22:15 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id A8E70A81F05; Tue, 30 Oct 2018 21:22:13 +0100 (CET) Date: Tue, 30 Oct 2018 20:22:00 -0000 From: Corinna Vinschen To: Pedro Alves Cc: joel@rtems.org, GDB patches Subject: Re: [PATCH] configure.ac: Cygwin now has ncurses not termcap. Use standard logic. Message-ID: <20181030202213.GA3310@calimero.vinschen.de> References: <1540415244-4879-1-git-send-email-joel@rtems.org> <8bc11746-527b-b123-0879-0c4cbd81eda3@redhat.com> <20181025185014.GN3310@calimero.vinschen.de> <16e94ff1-0c06-7cca-44b1-77bf2fa59519@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <16e94ff1-0c06-7cca-44b1-77bf2fa59519@redhat.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SW-Source: 2018-10/txt/msg00721.txt.bz2 Hi Pedro, I didn't see the patch before, sorry. I have an additional nit: On Oct 30 17:28, Pedro Alves wrote: > On 10/25/2018 07:50 PM, Corinna Vinschen wrote: > > On Oct 25 16:30, Pedro Alves wrote: > >> On 10/25/2018 04:01 PM, Joel Sherrill wrote: > >>> On Thu, Oct 25, 2018 at 9:34 AM Pedro Alves wrote: > >>> > >>>> WDTY by "now"? > >>>> > >>>> I mean Cygwin used to include libtermcap and this built. I updated my > >>> Cygwin this > >>> week and it is no longer there. I wasn't able to figure out when it went > >>> away. libncurses.a > >>> is included and that's suitable. > >>> > >> > >> That's so much clearer. > >> > >>> I cc'ed Corinna. I assume she can speak to when libtermcap.a was removed. > > > > I have no idea, ages ago. libncurses is used for a long time. Cygwin > > should use the same autoconf code to figure out the correct lib as any > > other target. > > Thanks, I've added info the commit log and applied the patch, as below. > [...] > diff --git a/sim/erc32/configure.ac b/sim/erc32/configure.ac > index 3135dc55ec..e4df81989c 100644 > --- a/sim/erc32/configure.ac > +++ b/sim/erc32/configure.ac > @@ -26,12 +26,11 @@ AC_CACHE_CHECK([for cygwin], sim_cv_os_cygwin, > lose > #endif],[sim_cv_os_cygwin=yes],[sim_cv_os_cygwin=no])]) > > +# Keep in sync with gdb's configure.ac list. > +AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncurses], > + [TERMCAP=$ac_cv_search_tgetent], [TERMCAP=""]) > if test x$sim_cv_os_cygwin = xyes; then > - TERMCAP='`if test -r ../../libtermcap/libtermcap.a; then echo ../../libtermcap/libtermcap.a; else echo -ltermcap; fi` -luser32' > -else > - # Keep in sync with gdb's configure.ac list. > - AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncurses], > - [TERMCAP=$ac_cv_search_tgetent], [TERMCAP=""]) > + TERMCAP="${TERMCAP} -luser32" This entire special code block for Cygwin should go away. The only reason to keep it is to add -luser32, but that's default for Cygwin applications anyway, per the GCC config(*). The less special cases in configure, the better, me thinks. Thanks, Corinna (*) https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=blob;f=gcc/config/i386/cygwin.h;h=fd7df56a18a5b44315eaac821f8ef65e41dcca46;hb=HEAD#l92