From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88241 invoked by alias); 28 Oct 2018 18:10:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88231 invoked by uid 89); 28 Oct 2018 18:10:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=encrypted, H*F:U*john, fingerprint X-HELO: jocasta.intra Received: from de.cellform.com (HELO jocasta.intra) (88.217.224.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 28 Oct 2018 18:10:21 +0000 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.15.2/8.15.2/Debian-8) with ESMTPS id w9SIABKa020318 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 28 Oct 2018 19:10:11 +0100 Received: (from john@localhost) by jocasta.intra (8.15.2/8.15.2/Submit) id w9SIAApW020317; Sun, 28 Oct 2018 19:10:10 +0100 Date: Sun, 28 Oct 2018 18:10:00 -0000 From: John Darrington To: Simon Marchi Cc: Sergio Durigan Junior , John Darrington , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] GDBSERVER: Listen on a unix domain (instead of TCP) socket if requested. Message-ID: <20181028181010.yt2xlp5in65xsc4f@jocasta.intra> References: <20181013175801.2670-1-john@darrington.wattle.id.au> <87a7nbxb2v.fsf@redhat.com> <20181019185548.izouwatbcjwnrs2a@jocasta.intra> <877eidwwlz.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-10/txt/msg00675.txt.bz2 Mea Culpa. I missed that one. I'll try to get a mingw environment set up and check in a fix. J' On Sun, Oct 28, 2018 at 12:20:28PM -0400, Simon Marchi wrote: On 2018-10-19 3:43 p.m., Sergio Durigan Junior wrote: > On Friday, October 19 2018, John Darrington wrote: > >> On Thu, Oct 18, 2018 at 04:18:48PM -0400, Sergio Durigan Junior wrote: >> >> > + bool is_unix = hint->ai_family == AF_UNIX; >> >> No need for a newline between the declarations of is_ipv6 and is_unix. >> >> Here, and everywhere else, AF_UNIX may be undefined if building GDB on a >> non-UNIX environment. I'm afraid you may have to guard this code with >> "HAVE_SYS_UN_H". >> >> >> This is true. But a quick experiment showed me that there are quite a >> few other places in gdb which has this problem. > > Which places? There are some files that are not compiled on certain > systems, so it's fine to have system-dependent code without the guards. > I don't use proprietary OSes, so the way I test here is to compile GDB > using a mingw compiler. If it passes, then I assume things are OK. > Your patch, for example, broke the compilation (because of > AF_UNIX/AF_LOCAL). > > Cheers, > I just tried compiling with mingw and stumbled on this: CXX common/netstuff.o /home/simark/src/binutils-gdb/gdb/common/netstuff.c: In function ???parsed_connection_spec parse_connection_spec(const char*, addrinfo*)???: /home/simark/src/binutils-gdb/gdb/common/netstuff.c:148:18: error: ???AF_LOCAL??? was not declared in this scope { "unix:", AF_LOCAL, SOCK_STREAM }, ^~~~~~~~ What is the status on this? Simon -- Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key.