From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61325 invoked by alias); 26 Oct 2018 07:32:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59832 invoked by uid 89); 26 Oct 2018 07:32:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Oct 2018 07:32:10 +0000 Received: by mail-wm1-f65.google.com with SMTP id 189-v6so443533wmw.2 for ; Fri, 26 Oct 2018 00:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DAI2aKBqjc6ri5AOmi/67ZznreE7BqXqBwfYREjpikY=; b=SBcvPOWtaHNPRGoAQDB8SzvKdmtZmSZoJDmL/zm+YDokfIyZNTj94/l+5F13DZ2AGa vYkJGjdFszti2TK+opCEnANFklzT1OjV5PR33X6+iUAb9rq5xeeG0sOlRJK6stXWznRl LjkJrWAVn7sp2uXZnadd3p0yKgPBGRa8p6zjBAp5SRK3BAMLi1ZADIgkZO0QTPjihJ5n U7Iw0u6fr4dXnru515+Gm52URLjIeu/68Atz0QUSSbkReB3tjqEIgFPAIKr0YiyeiS/t GQAVHcESnwonGxEqQH4l+9CGaxOnkLzQhbaQoxg0yUFjYEciHPb/CYrdqoka9Sy1OoNj IS1Q== Return-Path: Received: from localhost (host81-148-252-35.range81-148.btcentralplus.com. [81.148.252.35]) by smtp.gmail.com with ESMTPSA id 82-v6sm958202wmr.16.2018.10.26.00.32.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Oct 2018 00:32:06 -0700 (PDT) Date: Fri, 26 Oct 2018 07:32:00 -0000 From: Andrew Burgess To: Jim Wilson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/2] RISC-V: Linux signal frame support. Message-ID: <20181026073205.GQ2929@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: Money is better than poverty, if only for financial reasons. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00613.txt.bz2 * Jim Wilson [2018-10-25 16:58:51 -0700]: > This adds initial support for unwinding through signal trampolines. > I've tested it by hand and can see correct register values for the > frame where the signal occurred. I've tested it with the gdb > testsuite on an unleashed board with fc29 and a patched kernel, and I > get 37 more passes and 35 fewer failures. > > The result isn't as good as I hoped, as I'm getting a lot of failures > from the fact that stepi into handler doesn't work, but that > apparently is not expected to work with software single step which is > all I have implemented so far. > > This also fixes some duplicate comments the way that Simon Marchi > suggested back in August, by moving them to a .h file and modifying > the .c file to refer to the comments in the .h file. This series looks good to me. Thanks, Andrew