From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-151889-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 77450 invoked by alias); 26 Oct 2018 03:25:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 77441 invoked by uid 89); 26 Oct 2018 03:25:33 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Oct 2018 03:25:31 +0000
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id AAAD83082AEE;	Fri, 26 Oct 2018 03:25:30 +0000 (UTC)
Received: from pinnacle.lan (ovpn-116-78.phx2.redhat.com [10.3.116.78])	by smtp.corp.redhat.com (Postfix) with ESMTPS id 722BB60F80;	Fri, 26 Oct 2018 03:25:30 +0000 (UTC)
Date: Fri, 26 Oct 2018 03:25:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Jim Wilson <jimw@sifive.com>
Subject: Re: [PATCH 1/2] RISC-V: Linux signal frame support.
Message-ID: <20181025202529.5b52880e@pinnacle.lan>
In-Reply-To: <20181025235935.3781-1-jimw@sifive.com>
References: <CAFyWVaYFSWGfC_idDngHGd6fMKO8n2hohzdXWXcBh0MoqCqfTA@mail.gmail.com>	<20181025235935.3781-1-jimw@sifive.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2018-10/txt/msg00607.txt.bz2

On Thu, 25 Oct 2018 16:59:35 -0700
Jim Wilson <jimw@sifive.com> wrote:

> Make riscv_isa_flen available to the linux native code, and clean up duplicate
> comments.
> 
> 	gdb/
> 	* riscv-tdep.c (riscv_isa_xlen): Refer to riscv-tdep.h comment.
> 	(riscv_isa_flen): Likewise.  Drop static.
> 	* riscv-tdep.h (riscv_isa_xlen): Move riscv-tdep.c comment to here.
> 	(riscv_isa_flen): Likewise.

Maybe:

	(riscv_isa_flen): Likewise; declare.

?

Otherwise, LGTM.

Kevin