From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48833 invoked by alias); 19 Oct 2018 18:55:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48803 invoked by uid 89); 19 Oct 2018 18:55:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: jocasta.intra Received: from de.cellform.com (HELO jocasta.intra) (88.217.224.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Oct 2018 18:55:56 +0000 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.15.2/8.15.2/Debian-8) with ESMTPS id w9JItmNX006885 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Oct 2018 20:55:48 +0200 Received: (from john@localhost) by jocasta.intra (8.15.2/8.15.2/Submit) id w9JItmVW006884; Fri, 19 Oct 2018 20:55:48 +0200 Date: Fri, 19 Oct 2018 18:55:00 -0000 From: John Darrington To: Sergio Durigan Junior Cc: John Darrington , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] GDBSERVER: Listen on a unix domain (instead of TCP) socket if requested. Message-ID: <20181019185548.izouwatbcjwnrs2a@jocasta.intra> References: <20181013175801.2670-1-john@darrington.wattle.id.au> <87a7nbxb2v.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a7nbxb2v.fsf@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-10/txt/msg00436.txt.bz2 On Thu, Oct 18, 2018 at 04:18:48PM -0400, Sergio Durigan Junior wrote: > + bool is_unix = hint->ai_family == AF_UNIX; No need for a newline between the declarations of is_ipv6 and is_unix. Here, and everywhere else, AF_UNIX may be undefined if building GDB on a non-UNIX environment. I'm afraid you may have to guard this code with "HAVE_SYS_UN_H". This is true. But a quick experiment showed me that there are quite a few other places in gdb which has this problem. I can prepare a separate patch to fix those. J'