From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21626 invoked by alias); 19 Oct 2018 07:05:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21215 invoked by uid 89); 19 Oct 2018 07:05:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*F:U*john X-HELO: jocasta.intra Received: from de.cellform.com (HELO jocasta.intra) (88.217.224.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Oct 2018 07:05:56 +0000 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.15.2/8.15.2/Debian-8) with ESMTPS id w9J75nes001826 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Oct 2018 09:05:49 +0200 Received: (from john@localhost) by jocasta.intra (8.15.2/8.15.2/Submit) id w9J75nUn001825; Fri, 19 Oct 2018 09:05:49 +0200 Date: Fri, 19 Oct 2018 07:05:00 -0000 From: John Darrington To: Sergio Durigan Junior Cc: John Darrington , gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] GDB: Fix documentation for invoking GDBSERVER Message-ID: <20181019070549.6zu5fcdftmefqtzs@jocasta.intra> References: <20181013175801.2670-1-john@darrington.wattle.id.au> <20181013175801.2670-3-john@darrington.wattle.id.au> <871s8nxaoj.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871s8nxaoj.fsf@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-10/txt/msg00419.txt.bz2 On Thu, Oct 18, 2018 at 04:27:24PM -0400, Sergio Durigan Junior wrote: On Saturday, October 13 2018, John Darrington wrote: > The documentation did not mention the possibility of invoking gdbserver > with the new connection forms such as tcp6:host:port. This change fixes > that. Thanks for the patch. As I mentioned while reviewing patch #1, there is a reason why gdbserver doesn't accept prefixes (which means that there isn't a mistake in the docs). If you go with my suggestion and implement just the support for the "unix:" prefix, then this patch will need to be changed because it still won't be correct to mention the "tcp" prefixes. Thanks for the reviews. How about instead, we just add a test to print an error/warning if someone tries to start gdbserver with a udp prefix? J' -- Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key.