Re: [PATCH 1/4] GDBSERVER: Listen on a unix domain (instead of TCP) socket if requested.

John Darrington
2018-10-19T18:55:58Z

On Thu, Oct 18, 2018 at 04:18:48PM -0400, Sergio Durigan Junior wrote:

> + bool is_unix = hint->ai_family == AF_UNIX;

No need for a newline between the declarations of is_ipv6 and is_unix.

Here, and everywhere else, AF_UNIX may be undefined if building GDB on a
non-UNIX environment. I'm afraid you may have to guard this code with
"HAVE_SYS_UN_H".

This is true. But a quick experiment showed me that there are quite a
few other places in gdb which has this problem.

I can prepare a separate patch to fix those.

J'