Re: [PATCH 3/4] GDB: Fix documentation for invoking GDBSERVER

Sergio Durigan Junior
2018-10-19T20:45:33Z

On Friday, October 19 2018, John Darrington wrote:

> On Thu, Oct 18, 2018 at 04:27:24PM -0400, Sergio Durigan Junior wrote:
> On Saturday, October 13 2018, John Darrington wrote:
>
> > The documentation did not mention the possibility of invoking gdbserver
> > with the new connection forms such as tcp6:host:port. This change fixes
> > that.
>
> Thanks for the patch.
>
> As I mentioned while reviewing patch #1, there is a reason why gdbserver
> doesn't accept prefixes (which means that there isn't a mistake in the
> docs). If you go with my suggestion and implement just the support for
> the "unix:" prefix, then this patch will need to be changed because it
> still won't be correct to mention the "tcp" prefixes.
>
> Thanks for the reviews.
>
> How about instead, we just add a test to print an error/warning if
> someone tries to start gdbserver with a udp prefix?

Hm, I thought about that while writing the email, but at the time it
didn't seem like a good option. However, thinking about it again, I
think it would be mostly fine. I guess it's OK to support the
"tcp{,6}:" prefixes.

The check needs to implemented on gdbserver/remote-utils.c:remote_open,
and gdbserver needs to error out if "hint.ai_protocol == IPPROTO_UDP".
And "parse_connection_spec_without_prefix" could be merged with
"parse_connection_spec".

Aside from the documentation, you'd also probably have to update the
tests (both the selftests and the regular ones).

Thanks,

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible