Re: [PATCH 1/4] GDBSERVER: Listen on a unix domain (instead of TCP) socket if requested.

Simon Marchi
2018-10-31T13:54:49Z

On 2018-10-29 1:34 p.m., John Darrington wrote:
> On Mon, Oct 29, 2018 at 12:42:43PM -0400, Sergio Durigan Junior wrote:
>
> > If you think it necesary however I can revert anything you think hasn't
> > had enough discussion.
>
> Yes, please. The patch series is not ready to be pushed yet; there are
> a bunch of points I raised that were not addressed (and are now causing
> the failures). I am not a global maintainer, but it is my opinion that
> the patch series should be reverted for now. We can continue discussing
> and fixing things with it here in the list.
>
> Done.
>
> Start discussing.

Well, there are these two loose ends.

https://sourceware.org/ml/gdb-patches/2018-10/msg00438.html
https://sourceware.org/ml/gdb-patches/2018-10/msg00465.html

Also, please check why this series made the buildbot go crazy in
the native-extended-gdbserver configuration:

https://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/11314

It was suggested on IRC that the scoped_free_addrinfo in remote-utils.c is
at a wrong place, causing something to be used after free.

Simon