From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-151570-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 76401 invoked by alias); 12 Oct 2018 04:54:51 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 75980 invoked by uid 89); 12 Oct 2018 04:54:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Oct 2018 04:54:50 +0000
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 1227C3001772;	Fri, 12 Oct 2018 04:54:49 +0000 (UTC)
Received: from pinnacle.lan (ovpn-117-243.phx2.redhat.com [10.3.117.243])	by smtp.corp.redhat.com (Postfix) with ESMTPS id CA5718CCFC;	Fri, 12 Oct 2018 04:54:48 +0000 (UTC)
Date: Fri, 12 Oct 2018 04:54:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 6/8] Avoid shadowing in fdwalk
Message-ID: <20181011215447.4edb784c@pinnacle.lan>
In-Reply-To: <20180923040814.27941-7-tom@tromey.com>
References: <20180923040814.27941-1-tom@tromey.com>	<20180923040814.27941-7-tom@tromey.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2018-10/txt/msg00288.txt.bz2

On Sat, 22 Sep 2018 22:08:12 -0600
Tom Tromey <tom@tromey.com> wrote:

> -Wshadow=local caught this buglet.  fdwalk redeclares "result" in the
> inner scope, meaning that this function will always return 0, even on
> error.

Wow!

> gdb/ChangeLog
> 2018-09-22  Tom Tromey  <tom@tromey.com>
> 
> 	* common/filestuff.c (fdwalk): Remove inner declaration of
> 	"result".

This is okay.

Kevin