From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-151568-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 58197 invoked by alias); 12 Oct 2018 04:27:09 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 58185 invoked by uid 89); 12 Oct 2018 04:27:09 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=spots, Hx-languages-length:466, management
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Oct 2018 04:27:08 +0000
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 2B675307D943;	Fri, 12 Oct 2018 04:27:07 +0000 (UTC)
Received: from pinnacle.lan (ovpn-117-243.phx2.redhat.com [10.3.117.243])	by smtp.corp.redhat.com (Postfix) with ESMTPS id E95D08CCEA;	Fri, 12 Oct 2018 04:27:06 +0000 (UTC)
Date: Fri, 12 Oct 2018 04:27:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/8] Use std::string in mdebugread.c
Message-ID: <20181011212705.0e84054b@pinnacle.lan>
In-Reply-To: <20180923040814.27941-4-tom@tromey.com>
References: <20180923040814.27941-1-tom@tromey.com>	<20180923040814.27941-4-tom@tromey.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2018-10/txt/msg00286.txt.bz2

On Sat, 22 Sep 2018 22:08:09 -0600
Tom Tromey <tom@tromey.com> wrote:

> This changes a couple of spots in mdebugread to use std::string rather
> than manual management.  This is simpler, and also avoids shadowing by
> renaming the variable in question.
> 
> gdb/ChangeLog
> 2018-09-22  Tom Tromey  <tom@tromey.com>
> 
> 	* mdebugread.c (parse_partial_symbols): Use std::string.

You're right, it is simpler.

LGTM.

Kevin