From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14273 invoked by alias); 12 Oct 2018 04:19:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13956 invoked by uid 89); 12 Oct 2018 04:19:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:621, UD:server.c, serverc, server.c X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Oct 2018 04:19:12 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3060F637E4; Fri, 12 Oct 2018 04:19:11 +0000 (UTC) Received: from pinnacle.lan (ovpn-117-243.phx2.redhat.com [10.3.117.243]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F00CC118DD8; Fri, 12 Oct 2018 04:19:10 +0000 (UTC) Date: Fri, 12 Oct 2018 04:19:00 -0000 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/8] Avoid shadowing in gdbserver Message-ID: <20181011211909.621fb9fb@pinnacle.lan> In-Reply-To: <20180923040814.27941-3-tom@tromey.com> References: <20180923040814.27941-1-tom@tromey.com> <20180923040814.27941-3-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00285.txt.bz2 On Sat, 22 Sep 2018 22:08:08 -0600 Tom Tromey wrote: > This fixes a few instances of shadowing in gdbserver. These are all > simple fixes. > > gdb/gdbserver/ChangeLog > 2018-09-22 Tom Tromey > > * server.c (handle_status): Rename inner "thread". > (process_serial_event): Declare "res" in 'm' case. > * linux-low.c (last_thread_of_process_p, find_lwp_pid) > (iterate_over_lwps): Rename inner "thread". > (linux_qxfer_libraries_svr4): Rename inner "len". > * gdbthread.h (find_thread_in_random): Rename inner "thread". This is okay. Kevin