From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84920 invoked by alias); 9 Oct 2018 13:25:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81492 invoked by uid 89); 9 Oct 2018 13:24:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Oct 2018 13:24:56 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BC5D0308ED4D; Tue, 9 Oct 2018 13:24:44 +0000 (UTC) Received: from blade.nx (ovpn-117-250.ams2.redhat.com [10.36.117.250]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8417E6F4FB; Tue, 9 Oct 2018 13:24:44 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id B18E5803E602; Tue, 9 Oct 2018 14:24:43 +0100 (BST) Date: Tue, 09 Oct 2018 13:25:00 -0000 From: Gary Benson To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix buffer overrun found by Coverity Message-ID: <20181009132442.GA12668@blade.nx> References: <1538747591-32283-1-git-send-email-gbenson@redhat.com> <87o9c8h3y9.fsf@tromey.com> <20181008163422.GA8415@blade.nx> <87tvlwfiat.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tvlwfiat.fsf@tromey.com> X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00209.txt.bz2 Tom Tromey wrote: > >>>>> "Gary" == Gary Benson writes: > > Gary> I don't *think* it's necessary: > [...] > > I agree, thanks for breaking it down for me. > > Gary> Ok, so this one's built and regtested on RHEL 7.5 x86_64 now, > Gary> with the fission-dwp.exp board. Assuming the dimensions thing > Gary> above is correct, is this ok to commit? > > Yes, thank you. Cool, I've pushed it. Thanks for the review :D Cheers, Gary