Re: [PATCH 4/4] GDB: New target s12z

Tom Tromey
2018-09-08T13:16:36Z

>>>>> "John" == John Darrington <john@darrington.wattle.id.au> writes:

Tom> Is this stuff useful?

John> I suspect not. In fact, I'm very dubious about the whole
John> skip_prologue_using_sal function. It seems to not work very well.

John> + /* JPB: 28-Apr-11. This is a temporary patch, to get round GDB
John> + crashing right at the beginning. Build the frame ID as best we
John> + can. */
John> + trad_frame_set_id (info, frame_id_build (this_sp, this_pc));

Tom> Could you explain this more?

John> I'm afraid I can't. This was code I took over from the or1k target.

Ok; in that case I think you should drop these parts from the patch.

Tom