Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 7/8] Shadowing fix in gdbscm_frame_read_var
Date: Sun, 23 Sep 2018 04:08:00 -0000	[thread overview]
Message-ID: <20180923040814.27941-8-tom@tromey.com> (raw)
In-Reply-To: <20180923040814.27941-1-tom@tromey.com>

-Wshadow=local pointed out that the shadowing in gdbscm_frame_read_var
means that the ultimate call to read_var_value will always be passed
block==NULL.  The fix is to remove the outer declaration.

gdb/ChangeLog
2018-09-22  Tom Tromey  <tom@tromey.com>

	* guile/scm-frame.c (gdbscm_frame_read_var): Remove inner
	declaration of "block".
---
 gdb/ChangeLog         | 5 +++++
 gdb/guile/scm-frame.c | 1 -
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/guile/scm-frame.c b/gdb/guile/scm-frame.c
index 3d27907e19..5a056de332 100644
--- a/gdb/guile/scm-frame.c
+++ b/gdb/guile/scm-frame.c
@@ -878,7 +878,6 @@ gdbscm_frame_read_var (SCM self, SCM symbol_scm, SCM rest)
     }
   else if (scm_is_string (symbol_scm))
     {
-      const struct block *block = NULL;
       struct gdb_exception except = exception_none;
 
       if (! SCM_UNBNDP (block_scm))
-- 
2.17.1


  parent reply	other threads:[~2018-09-23  4:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-23  4:08 [PATCH 0/8] Add -Wshadow=local Tom Tromey
2018-09-23  4:08 ` [PATCH 2/8] Avoid shadowing in gdbserver Tom Tromey
2018-10-12  4:19   ` Kevin Buettner
2018-09-23  4:08 ` [PATCH 5/8] Fix latent bug in msp430-tdep.c Tom Tromey
2018-10-12  4:10   ` Kevin Buettner
2018-09-23  4:08 ` [PATCH 3/8] Use std::string in mdebugread.c Tom Tromey
2018-10-12  4:27   ` Kevin Buettner
2018-09-23  4:08 ` [PATCH 8/8] Add -Wshadow=local Tom Tromey
2018-09-23  4:08 ` Tom Tromey [this message]
     [not found]   ` <6d098a36-c483-77b8-61a6-87768c29f5d5@ericsson.com>
2018-10-04 12:44     ` [PATCH 7/8] Shadowing fix in gdbscm_frame_read_var Tom Tromey
2018-09-23  4:08 ` [PATCH 4/8] Avoid shadowing in linux-tdep.c Tom Tromey
2018-10-12  4:50   ` Kevin Buettner
2018-09-23  4:08 ` [PATCH 6/8] Avoid shadowing in fdwalk Tom Tromey
2018-10-12  4:54   ` Kevin Buettner
2018-09-23  4:09 ` [PATCH 1/8] Simple -Wshadow=local fixes Tom Tromey
2018-10-04  3:36   ` Simon Marchi
2018-10-04 12:22     ` Simon Marchi
2018-10-04 12:43       ` Tom Tromey
2018-10-03 15:02 ` [PATCH 0/8] Add -Wshadow=local Simon Marchi
     [not found]   ` <c0393dbe-9dbe-837a-b93d-7c2825ef3649@ericsson.com>
     [not found]     ` <04748d1d-0fe6-76ad-31f1-68657f8e0d56@redhat.com>
2018-10-03 17:53       ` Joel Brobecker
2018-10-05  4:57         ` Tom Tromey
2018-10-05  9:06           ` Rainer Orth
2018-10-05 11:14             ` Joel Brobecker
2018-10-05 13:37             ` [SPAM] " Tom Tromey
2018-10-05 15:58               ` Rainer Orth
2018-10-12  5:25 ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180923040814.27941-8-tom@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox