From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63246 invoked by alias); 18 Sep 2018 15:03:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63230 invoked by uid 89); 18 Sep 2018 15:03:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 15:03:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BF3741161F0; Tue, 18 Sep 2018 11:03:29 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HYaenmsKSsfC; Tue, 18 Sep 2018 11:03:29 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8BF8311618A; Tue, 18 Sep 2018 11:03:29 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9E8D4873D9; Tue, 18 Sep 2018 08:03:27 -0700 (PDT) Date: Tue, 18 Sep 2018 15:03:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: GDB Patches Subject: Re: [PATCH] Expect for "@" when doing "complete break ada" on gdb.ada/complete.exp Message-ID: <20180918150327.GK19172@adacore.com> References: <20180917213334.4468-1-sergiodj@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180917213334.4468-1-sergiodj@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-09/txt/msg00634.txt.bz2 Hi Sergio, Thanks for the patch! > Currently, gdb.ada/complete.exp's "complete break ada" test fails > because the regexp used to match the command's output doesn't expect > "@", but we have an output like: > > ... > complete break ada > break ada.assertions.assert > break ada.calendar.arithmetic.difference > break ada.calendar.arithmetic_operations.add > break ada.calendar.arithmetic_operations.add.cold > break ada.calendar.arithmetic_operations.add@plt > break ada.calendar.arithmetic_operations.difference > break ada.calendar.arithmetic_operations.difference@plt > ... > > This patch adds "@" to the regexp, unbreaking the test. > > OK? > > gdb/testsuite/ChangeLog: > 2018-09-17 Sergio Durigan Junior > > * gdb.ada/complete.exp: Expect for "@" when doing "complete > break ada". I can see this behavior, but only when I link with the shared version of libgnat. For us at least, on x86_64-linux, this is not the default. That's probably why I wasn't seeing this. This is OK. > gdb/testsuite/gdb.ada/complete.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.ada/complete.exp b/gdb/testsuite/gdb.ada/complete.exp > index cb9e4ae7ff..ac2bf85077 100644 > --- a/gdb/testsuite/gdb.ada/complete.exp > +++ b/gdb/testsuite/gdb.ada/complete.exp > @@ -218,7 +218,7 @@ gdb_test_no_output "set max-completions unlimited" > > set test "complete break ada" > gdb_test_multiple "$test" $test { > - -re "^$test$eol\(break ada(\[a-z0-9._\])*$eol\)+$gdb_prompt $" { > + -re "^$test$eol\(break ada(\[a-z0-9._@\])*$eol\)+$gdb_prompt $" { > pass $test > } > -re "\[A-Z\].*$gdb_prompt $" { > -- > 2.17.1 -- Joel