From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Check for gmp when checking for mpfr
Date: Mon, 17 Sep 2018 18:18:00 -0000 [thread overview]
Message-ID: <20180917181803.GC19172@adacore.com> (raw)
In-Reply-To: <20180916184502.19617-2-tom@tromey.com>
Hi Tom,
On Sun, Sep 16, 2018 at 12:45:01PM -0600, Tom Tromey wrote:
> There was a report on irc that the gdb check for mpfr failed when only
> static libraries are available. The issue is that mpfr depends on
> gmp, but this is not handled explicitly by gdb.
>
> Ideally upstream would switch to pkg-config. Or even more ideally, we
> would incorporate pkg-config into the compiler and not mess with any
> of this.
>
> Meanwhile, this changes gdb's configure to add gmp to the link line
> when checking for mpfr.
>
> ChangeLog
> 2018-09-16 Tom Tromey <tom@tromey.com>
>
> * configure: Rebuild.
> * configure.ac: Use gmp as a library dependency when checking for
> mpfr.
Thanks for the patch. This looks good to me.
--
Joel
next prev parent reply other threads:[~2018-09-17 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-16 18:45 [PATCH 0/2] two small configure patches Tom Tromey
2018-09-16 18:46 ` [PATCH 1/2] Check for gmp when checking for mpfr Tom Tromey
2018-09-17 18:18 ` Joel Brobecker [this message]
2018-09-16 18:46 ` [PATCH 2/2] Do not pass -DNDEBUG to Python compilations in development mode Tom Tromey
2018-09-17 18:19 ` Joel Brobecker
2018-09-17 18:22 ` Tom Tromey
2018-09-17 19:53 ` Tom Tromey
2018-09-17 21:21 ` Joel Brobecker
2018-09-17 21:22 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917181803.GC19172@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox