Re: [PATCH] compile: Remove non-const reference parameters

Keith Seitz
2018-09-17T13:29:19Z

On 09/16/2018 11:31 PM, Tom Tromey wrote:
> I think this particular change introduced a regression. runtest
> gdb.compile/*.exp causes gdb to crash for me several times on x86-64
> Fedora 28.

Fedora 28 is really broken right now. I have patches to fix almost
everything*, but I am struggling to understand why one of them is needed.
AFAICT, either __builtin_memcpy has usage changes that I missed, or there is
a glibc bug here. ["compile print" is completely broken -- the
__builtin_memcpy on Fedora 28 does nothing. Works fine on my Fedora 21
and 26 boxes.]

Using __builtin_memmove works fine, though. [And just to state the obvious,
no, the memory regions do not overlap.]

Keith

* "Everything" = everything except what appears to be a newly introduced GCC
8 bug that causes regressions in compile-cplus-method.exp.