From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 3/3] Use GNU style for metasyntactic variables in gdbserver
Date: Sat, 15 Sep 2018 02:55:00 -0000 [thread overview]
Message-ID: <20180915025522.18723-4-tom@tromey.com> (raw)
In-Reply-To: <20180915025522.18723-1-tom@tromey.com>
This changes a couple of places in gdbserver to use the GNU style for
metasyntactic variables.
2018-09-14 Tom Tromey <tom@tromey.com>
* remote-utils.c (remote_open): Use GNU style for metasyntactic
variables.
* gdbreplay.c (gdbreplay_usage): Use GNU style for metasyntactic
variables.
---
gdb/gdbserver/ChangeLog | 7 +++++++
gdb/gdbserver/gdbreplay.c | 2 +-
gdb/gdbserver/remote-utils.c | 2 +-
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/gdb/gdbserver/gdbreplay.c b/gdb/gdbserver/gdbreplay.c
index b05209c4d14..9e81541712e 100644
--- a/gdb/gdbserver/gdbreplay.c
+++ b/gdb/gdbserver/gdbreplay.c
@@ -448,7 +448,7 @@ gdbreplay_version (void)
static void
gdbreplay_usage (FILE *stream)
{
- fprintf (stream, "Usage:\tgdbreplay <logfile> <host:port>\n");
+ fprintf (stream, "Usage:\tgdbreplay LOGFILE HOST:PORT\n");
if (REPORT_BUGS_TO[0] && stream == stdout)
fprintf (stream, "Report bugs to \"%s\".\n", REPORT_BUGS_TO);
}
diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
index 38c90324288..9199a9c7add 100644
--- a/gdb/gdbserver/remote-utils.c
+++ b/gdb/gdbserver/remote-utils.c
@@ -336,7 +336,7 @@ remote_open (const char *name)
port_str = strchr (name, ':');
#ifdef USE_WIN32API
if (port_str == NULL)
- error ("Only <host>:<port> is supported on this platform.");
+ error ("Only HOST:PORT is supported on this platform.");
#endif
if (strcmp (name, STDIO_CONNECTION_NAME) == 0)
--
2.17.1
next prev parent reply other threads:[~2018-09-15 2:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 2:55 [PATCH 0/3] More use of GNU-style metasyntactic variables Tom Tromey
2018-09-15 2:55 ` Tom Tromey [this message]
2018-09-16 3:17 ` [PATCH 3/3] Use GNU style for metasyntactic variables in gdbserver Simon Marchi
2018-09-15 2:55 ` [PATCH 2/3] Use GNU style for metasyntactic variables in gdb Tom Tromey
2018-09-16 3:17 ` Simon Marchi
2018-09-16 12:13 ` Tom Tromey
2018-09-16 3:20 ` Simon Marchi
2018-09-16 12:16 ` Tom Tromey
2018-09-16 12:42 ` Tom Tromey
2018-09-15 2:55 ` [PATCH 1/3] Expand "show disassembler-options" output Tom Tromey
2018-09-16 3:12 ` Simon Marchi
2018-09-16 12:18 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180915025522.18723-4-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox