Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c

Romain Naour
2018-09-15T13:16:31Z

Hi Joel, All,

Le 15/09/2018 Ã  00:09, Joel Brobecker a Ã©critÂ :
> Hello Romain,
>
>>> Me too. I can backport it to 8.2 if wanted.
>>
>> Yes please for the upcoming 8.2.1.
>
> Once a release has been made off a give branch, there are a couple
> of additional conditions before we can backport that change to
> that branch:
>
> - The patch needs to be safe, and you need approval from a Global
> Maintainer to do so;
>
> I looked at the patch, and although I was nervous about
> the removal of the <stat.h> #include at first, I checked
> the contents of the file, and I am reasonably certain that
> there isn't any other code that might needed on some obscure
> system. So you have my OK for the patch to be backported to
> the gdb-8.2-branch.

Ok, thanks.
Note that Sergio is the original author of this part of the code introduced with
gdb 8.2 and backported to gdb 8.1.1 [1].

>
> - And the commit should have a corresponding GDB PR number
> (https://sourceware.org/bugzilla/); the PR number acts as
> a reference for "what's changed" in each corrective release,
> so the clearer the explanation in the description, the better.
>
> If you are the one motivated for the backport, it would be
> helpful if you could take care of creating the PR. Sergio
> offered to then backport it for you, but I can also help
> with that.

I'm agree on the principle but the change from gdb 8.2 introducing the issue has
been backported to gdb 8.1.x [1] without such GDB PR number (as far I can see).
IIUC, all patches backported to a stable branch must have a GDB PR number.
This is not always the case.

Without the fix provided by Sergio (Thanks!) we can't build gdb with a musl
toolchain, so gdb 8.1.x and gdb 8.2.x remain unfixed.

I'll create the GDB PR but all explanations of the issue have been provided on
the mailing list by gdb developers and maintainers.

[1]
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=2441702a72f324e41a1624dc042b334f375e2d81

Best regards,
Romain

>
> Thank you,
>