Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c

Sergio Durigan Junior
2018-09-16T04:59:15Z

On Saturday, September 15 2018, Romain Naour wrote:

> Hi Sergio,
>
> Le 15/09/2018 à 22:35, Sergio Durigan Junior a écrit :
>> On Saturday, September 15 2018, Romain Naour wrote:
>>
>>>> - And the commit should have a corresponding GDB PR number
>>>> (https://sourceware.org/bugzilla/); the PR number acts as
>>>> a reference for "what's changed" in each corrective release,
>>>> so the clearer the explanation in the description, the better.
>>>>
>>>> If you are the one motivated for the backport, it would be
>>>> helpful if you could take care of creating the PR. Sergio
>>>> offered to then backport it for you, but I can also help
>>>> with that.
>>>
>>> I'm agree on the principle but the change from gdb 8.2 introducing the issue has
>>> been backported to gdb 8.1.x [1] without such GDB PR number (as far I can see).
>>> IIUC, all patches backported to a stable branch must have a GDB PR number.
>>> This is not always the case.
>>
>> It is always the case. Joel kindly reminded me (back then) that I had
>> forgotten to create a PR for this backport:
>>
>> https://sourceware.org/ml/gdb-patches/2018-03/msg00001.html
>>
>> And I did it subsequently:
>>
>> https://sourceware.org/bugzilla/show_bug.cgi?id=22907
>>
>> Unfortunately, it was not possible to reference the PR number in the
>> commit log anymore, but it was included in the official release note:
>>
>> https://sourceware.org/ml/gdb-announce/2018/msg00002.html
>
> Sorry, I missed the reference to the PR.
> Thanks for the links.

No problem at all, it certainly wasn't obvious. Thanks for reporting
the bug and filing the PR :-).

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible