Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c

Pedro Alves
2018-09-12T17:41:48Z

On 09/12/2018 06:31 PM, Sergio Durigan Junior wrote:

> The most simple fix for this problem is to move 'is_regular_file' to
> 'filestuff.c', which is not used by IPA. This ends up making the
> files more logically organized as well, since 'is_regular_file' is a
> file operation.
>
> No regressions found.
>
> gdb/ChangeLog:
> 2018-09-12 Sergio Durigan Junior <sergiodj@redhat.com>
>
> * common/common-utils.c: Don't include '<sys/stat.h>'.
> (is_regular_file): Move to...
> * common/filestuff.c (is_regular_file): ... here.
> * common/common-utils.h (is_regular_file): Move to...
> * common/filestuff.h (is_regular_file): ... here.

OK.

Thanks,
Pedro Alves