From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7754 invoked by alias); 11 Sep 2018 06:47:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7735 invoked by uid 89); 11 Sep 2018 06:47:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=CTO, cto X-HELO: mail.bootlin.com Received: from mail.bootlin.com (HELO mail.bootlin.com) (62.4.15.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Sep 2018 06:47:03 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 10EEF20799; Tue, 11 Sep 2018 08:47:01 +0200 (CEST) Received: from windsurf (AAubervilliers-681-1-30-219.w90-88.abo.wanadoo.fr [90.88.15.219]) by mail.bootlin.com (Postfix) with ESMTPSA id CAC9C20703; Tue, 11 Sep 2018 08:47:00 +0200 (CEST) Date: Tue, 11 Sep 2018 06:47:00 -0000 From: Thomas Petazzoni To: Rich Felker Cc: Romain Naour , Romain Naour , buildroot@buildroot.org, gdb-patches@sourceware.org Subject: Re: [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system Message-ID: <20180911084659.786da210@windsurf> In-Reply-To: <20180910224128.GT1878@brightrain.aerifal.cx> References: <20180909163750.14196-1-romain.naour@gmail.com> <20180909163750.14196-2-romain.naour@gmail.com> <20180910174900.0b9f4133@windsurf> <20180910224128.GT1878@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00310.txt.bz2 Hello, On Mon, 10 Sep 2018 18:41:28 -0400, Rich Felker wrote: > I'm not aware of all the context, but it looks like different source > files disagree on whether gnulib has replaced stat or not -- the > gnulib source file thinks it hasn't, so the rpl_stat function isn't > defined, but gdb's common-utils-ipa.c file (or rather the gnulib > stat.h included into it?) thinks it has been replaced and is trying to > use the replacement. This is likely the result of an incorrect hack > somewhere. Do you know if it happens with upstream gdb and musl or > just in buildroot's package? Well, Buildroot is using upstream musl and gdb. For both packages, we have only very few patches: https://git.buildroot.org/buildroot/tree/package/musl/ https://git.buildroot.org/buildroot/tree/package/gdb/8.1.1/ Note that we already have a number of gnulib related hacks in gdb.mk: https://git.buildroot.org/buildroot/tree/package/gdb/gdb.mk#n77 Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com