From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111441 invoked by alias); 10 Sep 2018 17:43:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111430 invoked by uid 89); 10 Sep 2018 17:43:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=deliberately X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Sep 2018 17:43:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 05E4311773A; Mon, 10 Sep 2018 13:43:48 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id aogmXkP3pqtV; Mon, 10 Sep 2018 13:43:47 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CC1A6117632; Mon, 10 Sep 2018 13:43:47 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id EFE3183AD6; Mon, 10 Sep 2018 18:43:45 +0100 (BST) Date: Mon, 10 Sep 2018 17:43:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org, Jerome Guitton Subject: Re: [RFA] arm-pikeos: software single step Message-ID: <20180910174345.GD3234@adacore.com> References: <1536592407-13448-1-git-send-email-brobecker@adacore.com> <87sh2hs1n5.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sh2hs1n5.fsf@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-09/txt/msg00287.txt.bz2 > Joel> The challenge is that, up to now, the PikeOS target was in all respects > Joel> identical to a baremetal target as far as GDB was concerned, meaning > Joel> we were using the baremetal osabi for this target too. This is no longer > Joel> possible, and we need to introduce a new OSABI variant. > > I don't really know anything about this area, but... > > Is there any chance of introducing some flag into the object files so > that the heuristic could be removed at some future point? I don't really see this, because we don't really control the platform. > Joel> + > Joel> +static void > Joel> +arm_pikeos_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) > > The usual thing about functions needing an intro comment. OK, I will do that. I saw it, and grepped around, saw that it wasn't really done for the few spot checks I did, so thought it was just so obvious that it was deliberately omitted. > Joel> + { "Pikeos", NULL }, > > The email spelled it "PikeOS", so maybe it should read that way here as > well. Indeed, that's a good point. Thanks for the review, Tom. New version of the patch coming up. -- Joel