From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113262 invoked by alias); 8 Sep 2018 13:21:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113252 invoked by uid 89); 8 Sep 2018 13:21:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: jocasta.intra Received: from de.cellform.com (HELO jocasta.intra) (88.217.224.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Sep 2018 13:21:55 +0000 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.15.2/8.15.2/Debian-8) with ESMTPS id w88DLq8r013076 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 8 Sep 2018 15:21:52 +0200 Received: (from john@localhost) by jocasta.intra (8.15.2/8.15.2/Submit) id w88DLq9D013075; Sat, 8 Sep 2018 15:21:52 +0200 Date: Sat, 08 Sep 2018 13:21:00 -0000 From: John Darrington To: Tom Tromey Cc: John Darrington , gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] GDB: New target s12z Message-ID: <20180908132152.b5sk7iv6c7267u7t@jocasta.intra> References: <20180829141845.26378-1-john@darrington.wattle.id.au> <20180829141845.26378-5-john@darrington.wattle.id.au> <874lf1vuca.fsf@tromey.com> <20180908044605.ctlyone5vd4sx6jt@jocasta.intra> <87h8j05duz.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h8j05duz.fsf@tromey.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-09/txt/msg00164.txt.bz2 On Sat, Sep 08, 2018 at 07:16:04AM -0600, Tom Tromey wrote: >>>>> "John" == John Darrington writes: Tom> Is this stuff useful? John> I suspect not. In fact, I'm very dubious about the whole John> skip_prologue_using_sal function. It seems to not work very well. John> + /* JPB: 28-Apr-11. This is a temporary patch, to get round GDB John> + crashing right at the beginning. Build the frame ID as best we John> + can. */ John> + trad_frame_set_id (info, frame_id_build (this_sp, this_pc)); Tom> Could you explain this more? John> I'm afraid I can't. This was code I took over from the or1k target. Ok; in that case I think you should drop these parts from the patch. I will run some tests to see what ill efects there are (if any) without these bits. J'