From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58724 invoked by alias); 8 Sep 2018 04:22:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58708 invoked by uid 89); 8 Sep 2018 04:22:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: jocasta.intra Received: from de.cellform.com (HELO jocasta.intra) (88.217.224.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Sep 2018 04:22:01 +0000 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.15.2/8.15.2/Debian-8) with ESMTPS id w884LwcF026109 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 8 Sep 2018 06:21:58 +0200 Received: (from john@localhost) by jocasta.intra (8.15.2/8.15.2/Submit) id w884LwJ8026108; Sat, 8 Sep 2018 06:21:58 +0200 Date: Sat, 08 Sep 2018 04:22:00 -0000 From: John Darrington To: Tom Tromey Cc: John Darrington , gdb-patches@sourceware.org Subject: Re: [PATCH] Allow remote debugging over a Unix local domain socket. Message-ID: <20180908042158.wn5bmphbwzxpzm44@jocasta.intra> References: <20180903121736.5246-1-john@darrington.wattle.id.au> <20180903121736.5246-2-john@darrington.wattle.id.au> <87h8j1vwzs.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h8j1vwzs.fsf@tromey.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-09/txt/msg00153.txt.bz2 On Fri, Sep 07, 2018 at 03:05:59PM -0600, Tom Tromey wrote: >>>>> "John" == John Darrington writes: John> Extend the "target remote" and "target extended-remote" commands John> such that if the filename provided is a Unix local domain (AF_UNIX) John> socket, then it'll be treated as such, instead of trying to open John> it as if it were a character device. I think Pedro should have the final review on this, since he had more comments the last time around. Okay. Pedro? John> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo John> index 5068c0ac81..dae62c1787 100644 John> --- a/gdb/doc/gdb.texinfo John> +++ b/gdb/doc/gdb.texinfo John> @@ -20703,7 +20703,8 @@ programs. John> @code{target} command. John> + John> +@item target remote @var{local-socket} John> +@itemx target extended-remote @var{local-socket} That looked like one extra newline in there to me. I will fix that. Now that there are 3 copies of this in gdb, it would be good to unify them somewhere in common/. I agree. But shouldn't that be the subject of a separate change? J'