From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42834 invoked by alias); 7 Sep 2018 07:25:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36706 invoked by uid 89); 7 Sep 2018 07:25:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=tied, you! X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Sep 2018 07:25:29 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AFAA81177C8; Fri, 7 Sep 2018 03:25:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8GuIBnlVwqjK; Fri, 7 Sep 2018 03:25:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 68C0B1177C4; Fri, 7 Sep 2018 03:25:25 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D550A83AD3; Fri, 7 Sep 2018 09:25:22 +0200 (CEST) Date: Fri, 07 Sep 2018 07:25:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFC 0/8] add terminal styling to gdb Message-ID: <20180907072522.GA3952@adacore.com> References: <20180906211303.11029-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180906211303.11029-1-tom@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-09/txt/msg00117.txt.bz2 Hi Tom, > I've wanted gdb to use colors on the terminal for a while now. I've > actually tried implementing this a few different ways at different > times, the most successful approach so far being a colorizing frame > filter. > > This series takes a more direct approach, namely integrating the code > into gdb. The basic approach is to have gdb know how to emit ANSI > terminal escape codes to control the color and style (currently just > the intensity). Then, cli-out is changed to style certain fields as > it emits them. However, because some places do not use ui-out, some > ad hoc changes are also done. > > This series styles function names, file names, and variable names. It > also styles the gdb welcome message for fun. > > I think my earlier patch to make the TUI understand ANSI terminal > escapes will make this patch work there. (I have not tried this yet.) > > Other things could be styled as well. A few ideas I had: This is going to be a very nice improvement, thank you! I am a bit tied for time to take a first look at the implementation, but the approach sounds good to me. -- Joel