Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [RFC 0/8] add terminal styling to gdb
Date: Thu, 06 Sep 2018 21:13:00 -0000	[thread overview]
Message-ID: <20180906211303.11029-1-tom@tromey.com> (raw)

This series is not ready to review, but I wanted some feedback on the
general approach before committing to writing documentation, test
cases, and comments.

I've wanted gdb to use colors on the terminal for a while now.  I've
actually tried implementing this a few different ways at different
times, the most successful approach so far being a colorizing frame
filter.

This series takes a more direct approach, namely integrating the code
into gdb.  The basic approach is to have gdb know how to emit ANSI
terminal escape codes to control the color and style (currently just
the intensity).  Then, cli-out is changed to style certain fields as
it emits them.  However, because some places do not use ui-out, some
ad hoc changes are also done.

This series styles function names, file names, and variable names.  It
also styles the gdb welcome message for fun.

I think my earlier patch to make the TUI understand ANSI terminal
escapes will make this patch work there.  (I have not tried this yet.)

Other things could be styled as well.  A few ideas I had:

* Style addresses specially
* Style strings specially
* Add styling to "print" and "ptype" (like, field names could be
  styled the way they are in other spots in this series)
* Go the other way and instead of styling the names of variables,
  style their values
* Style gdb-provided identifiers specially so they can be found
  more easily; here I mean something like the thread number or
  breakpoint number, which you have to read to type back to gdb
  sometimes
* Inferior-provided identifiers (PID or thread name) could be styled
  differently too
* ... your idea here, let me know

Tom



             reply	other threads:[~2018-09-06 21:13 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06 21:13 Tom Tromey [this message]
2018-09-06 21:13 ` [RFC 7/8] Style the gdb welcome message Tom Tromey
2018-09-06 21:13 ` [RFC 3/8] Add output styles to gdb Tom Tromey
2018-10-06 15:53   ` Simon Marchi
2018-10-06 19:06     ` Tom Tromey
2018-10-07 21:58       ` Simon Marchi
2018-10-08  0:23         ` Tom Tromey
2018-10-08  2:02           ` Simon Marchi
2018-10-08  2:49             ` Tom Tromey
2018-10-08 11:10               ` Simon Marchi
2018-10-08 22:17                 ` Tom Tromey
2018-09-06 21:13 ` [RFC 1/8] Change wrap buffering to use a std::string Tom Tromey
2018-10-06 15:19   ` Simon Marchi
2018-10-08 22:04     ` Tom Tromey
2018-10-18 22:16       ` Tom Tromey
2018-09-06 21:13 ` [RFC 4/8] Add variable name styling Tom Tromey
2018-10-06 16:34   ` Simon Marchi
2018-09-06 21:13 ` [RFC 6/8] Style print_address_symbolic Tom Tromey
2018-09-06 21:13 ` [RFC 2/8] Add a "context" argument to add_setshow_enum_cmd Tom Tromey
2018-09-06 21:14 ` [RFC 8/8] Style the "Reading symbols" message Tom Tromey
2018-09-06 21:14 ` [RFC 5/8] Style locations when setting a breakpoint Tom Tromey
2018-10-06 16:36   ` Simon Marchi
2018-09-07  6:23 ` [RFC 0/8] add terminal styling to gdb Eli Zaretskii
2018-09-07 14:36   ` Tom Tromey
2018-09-07 14:56     ` Eli Zaretskii
2018-09-07 15:01       ` Eli Zaretskii
2018-09-07  7:25 ` Joel Brobecker
2018-10-04 13:11 ` Tom Tromey
2019-03-24 10:27 Konst Mayer
2019-03-25 15:07 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180906211303.11029-1-tom@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox