From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [FYI 0/2] Fix -Wformat-nonliteral
Date: Thu, 06 Sep 2018 03:39:00 -0000 [thread overview]
Message-ID: <20180906033855.13635-1-tom@tromey.com> (raw)
Simon pointed out today that my earlier patch to remove some custom
rules from the Makefile had broken his build.
We tracked this difference down to a bug in warning.m4:
-Wformat-nonliteral was not being enabled for builds with gcc. This
is why my build and the builders did not warn -- in fact the original
patch was incorrect.
This series fixes the problem using the diagnostic suppression code.
This seems a bit better because now the warning avoidance is more
targeted.
The first patch here is from Simon (I wrote the commit text and the
ChangeLog entry, in case they aren't up to par); but I'm committing it
on his behalf as he is traveling.
I'm checking this in.
Tom
next reply other threads:[~2018-09-06 3:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 3:39 Tom Tromey [this message]
2018-09-06 3:39 ` [FYI 1/2] Disable -Wformat-nonliteral in parts of printcmd.c Tom Tromey
2018-09-06 3:46 ` Tom Tromey
2018-09-06 3:39 ` [FYI 2/2] Make -Wformat-nonliteral work with gcc Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906033855.13635-1-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox