Re: [PATCH 2/4] Remove cleanup from procfs.c

Rainer Orth
2018-09-04T10:50:25Z

Hi Tom,

> This removes the last remaining cleanup from procfs.c, replacing it
> with a unique_ptr specialization.

I've now regtested the patch on amd64-pc-solaris2.11. After fixing one
compile failure

/vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:275:13: error: ‘void do_destroy_procinfo_cleanup(void*)’ declared ‘static’ but never defined [-Werror=unused-function]
static void do_destroy_procinfo_cleanup (void *);
^~~~~~~~~~~~~~~~~~~~~~~~~~~

by removing the unnecessary declaration, testing passed without
regressions (as far as I can tell with racy tests etc.).

Rainer

--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University