From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76749 invoked by alias); 31 Aug 2018 07:59:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76712 invoked by uid 89); 31 Aug 2018 07:59:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:677 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Aug 2018 07:59:39 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B3AAA1174C2; Fri, 31 Aug 2018 03:59:37 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DqMINFZqOT24; Fri, 31 Aug 2018 03:59:37 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 802DA1175FF; Fri, 31 Aug 2018 03:59:37 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 50AC586A7A; Fri, 31 Aug 2018 09:59:35 +0200 (CEST) Date: Fri, 31 Aug 2018 07:59:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: Simon Marchi , GDB Patches , Pedro Alves , Tom Tromey Subject: Re: [PATCH] Update gnulib/Makefile.in:aclocal_m4_deps Message-ID: <20180831075935.GA5568@adacore.com> References: <20180830155724.20000-1-sergiodj@redhat.com> <72e6edf3ddf2c9994c5e5d3ebfbfb171@polymtl.ca> <87bm9jiq05.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bm9jiq05.fsf@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-08/txt/msg00848.txt.bz2 > > This looks good to me, the set of m4 files listed here matches the > > list of actual m4 files in import/m4. Follow-up question, could we > > use $(wildcard ...) instead of listing them by hand? > > Yeah, I think that could work. That's basically what I did to generate > this list: "ls *.m4". If you want, I can edit the patch and make it use > $(wildcard) before pushing it. I would push the patch as is for now, since it is a necessary improvement on its own that doesn't really make the next step any more difficult than before; and then, if you are willing, work on using $(wildcard ...) as a followup. -- Joel