From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80382 invoked by alias); 30 Aug 2018 15:05:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80364 invoked by uid 89); 30 Aug 2018 15:05:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Aug 2018 15:05:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F228F1173B6; Thu, 30 Aug 2018 11:04:59 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4sjSao69PWmJ; Thu, 30 Aug 2018 11:04:59 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C3FD71173B2; Thu, 30 Aug 2018 11:04:59 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2686486A78; Thu, 30 Aug 2018 17:04:58 +0200 (CEST) Date: Thu, 30 Aug 2018 15:05:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org, Keith Seitz Subject: Re: [PATCH] Fix compile-cplus-types.c build errors Message-ID: <20180830150458.GA2617@adacore.com> References: <1535640184-20543-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1535640184-20543-1-git-send-email-simon.marchi@ericsson.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-08/txt/msg00828.txt.bz2 Hi Simon, > gdb/ChangeLog: > > * compile/compile-cplus-types.c > (compile_cplus_instance::enter_scope): Take the address of scope > object. > (compile_cplus_instance::leave_scope): Likewise. > (compile_cplus_instance::convert_qualified_base): Compare quals > to 0. [...] > diff --git a/gdb/compile/compile-cplus-types.c b/gdb/compile/compile-cplus-types.c > index 9425fc6..844c8ce 100644 > --- a/gdb/compile/compile-cplus-types.c > +++ b/gdb/compile/compile-cplus-types.c > @@ -259,7 +259,7 @@ compile_cplus_instance::enter_scope (compile_scope &new_scope) > if (must_push) > { > if (debug_compile_cplus_scopes) > - fprintf_unfiltered (gdb_stdlog, "entering new scope %p\n", new_scope); > + fprintf_unfiltered (gdb_stdlog, "entering new scope %p\n", &new_scope); While at it, can you change the use of %p by using %s combined with host_address_to_string? Using %p triggers an ARI warning. > @@ -1055,7 +1055,7 @@ compile_cplus_instance::convert_qualified_base (gcc_type base, > { > gcc_type result = base; > > - if (quals != GCC_CP_REF_QUAL_NONE) > + if (quals != 0) > result = plugin ().build_qualified_type (base, quals); > > return result; > -- > 2.7.4 -- Joel