From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28244 invoked by alias); 27 Aug 2018 11:04:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28074 invoked by uid 89); 27 Aug 2018 11:04:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=burgess, Burgess, highlighted, onboard X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Aug 2018 11:03:58 +0000 Received: by mail-wm0-f44.google.com with SMTP id c14-v6so7668622wmb.4 for ; Mon, 27 Aug 2018 04:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IIwRSoJ9XyWvxw99kb6ilRlxYZk55jnDH2kMBvQ0xKg=; b=QHA6Gz0U9XghCppAF6JkVWYgs+6GURxUJxPm7yeHlxIrOypXguhWq9ssDOsNKISp0W Poed5t08us+878S5O8MoWLfqveix+MW4ywVxrSH9C/DmV6vb4bAALUEyA2PPFtNq7l4Y Wch+mHzqroE7xxoSHgzinAcRyv266IOiJkUvA1DwB78z7gUXi9OCZiSRgmiCNWVYbBeh +xqzmGob+/tJdZXwtdjY422nOV4rFASmHFUvdrZOouO3KwChjxxVmw996sc7pM4M5qAt bURx/XQr3+Yrj1QGLJ1EsWff+ZiiQHCyxMfP1HanMMVOkD8gA61TgHNa0BQVeLpLvgUx ZpXg== Return-Path: Received: from localhost (host86-134-20-86.range86-134.btcentralplus.com. [86.134.20.86]) by smtp.gmail.com with ESMTPSA id l7-v6sm14443045wrt.67.2018.08.27.04.03.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Aug 2018 04:03:54 -0700 (PDT) Date: Mon, 27 Aug 2018 11:04:00 -0000 From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Philippe Waroquiers , Eli Zaretskii Subject: Re: [PATCHv5 0/2] gdb: Change how frames are selected for 'frame' and 'info frame'. Message-ID: <20180827110353.GE32506@embecosm.com> References: <20180725181406.GA3155@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: Spreading peanut butter reminds me of opera!! I wonder why? X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00645.txt.bz2 Ping! Eli: In this message: https://sourceware.org/ml/gdb-patches/2018-07/msg00670.html Philippe highlighted that you might have some reservations about this patch series, which I think is currently the main blocker for this patch getting approval. In the thread started here: https://sourceware.org/ml/gdb-patches/2018-05/msg00299.html and ending here: https://sourceware.org/ml/gdb-patches/2018-06/msg00142.html you did review and approve one of the original patch variants, which is most like the "level" variant of the patch submitted here: https://sourceware.org/ml/gdb-patches/2018-08/msg00337.html I would be really grateful if you could let me know your current thoughts on this patch, are you happy to have the "level" variant merged based on your previous approval, or has you position changed? Thanks. Philippe: Thanks for the review and feedback in: https://sourceware.org/ml/gdb-patches/2018-08/msg00349.html I wasn't sure if the second part of you mail was suggesting that those instances of level vs number needed to be resolved as part of this patch for you to be happy, or if this was just identifying what we should clean up if/when this patch is merged. Additional clarity here would help me figure out my next steps for getting this patch merged. Thanks. Many thanks to everyone who's taken time to review this for me. Thanks, Andrew * Andrew Burgess [2018-08-13 23:20:09 +0100]: > Given a lack of feedback on v4, I've put together two alternative > versions to pick between... > > (A) In this version I took onboard the feedback from Eli and > Philippe that using "level" might be confusing to users, as > "number" is historically what has been used for the integer > label we give to frames. > > The command for selecting a frame by integer is now, 'frame > number ' and almost all references to "level" have now > been removed from the patch. > > (B) In this version I've taken onboard the advice from Philippe, > identifying places in the patch where I was mixing use of > "level" and "number". I've doubled down on "level" and removed > most uses of "number" from the patch. > > If we select patch 'A' then me might want to update 'frame apply level > ...' to 'frame apply number ...' for consistency. > > If we select patch 'B' then we will probably need a follow up patch > that goes through the documentation to tighten up references to > "number" vs "level". > > I really don't mind which approach we take, I guess I'd probably pick > 'B' over 'A' given we already have 'frame apply level ...' in GDB, but > if there's preference for 'A' then that's fine. > > I'm also happy to do the follow up patches once we have some agreement > on which way to go. > > Thanks, > Andrew > > --- > > Andrew Burgess (1): > gdb: Change how frames are selected for 'frame' and 'info frame'. > > gdb/ChangeLog | 36 ++ > gdb/NEWS | 8 + > gdb/cli/cli-decode.c | 44 ++- > gdb/command.h | 14 + > gdb/doc/ChangeLog | 8 + > gdb/doc/gdb.texinfo | 108 ++++-- > gdb/mi/mi-cmd-stack.c | 4 +- > gdb/stack.c | 535 +++++++++++++++++++--------- > gdb/stack.h | 2 +- > gdb/testsuite/ChangeLog | 7 + > gdb/testsuite/gdb.base/frame-selection.c | 52 +++ > gdb/testsuite/gdb.base/frame-selection.exp | 157 ++++++++ > gdb/testsuite/gdb.mi/mi-frame-selection.c | 34 ++ > gdb/testsuite/gdb.mi/mi-frame-selection.exp | 89 +++++ > 14 files changed, 896 insertions(+), 202 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/frame-selection.c > create mode 100644 gdb/testsuite/gdb.base/frame-selection.exp > create mode 100644 gdb/testsuite/gdb.mi/mi-frame-selection.c > create mode 100644 gdb/testsuite/gdb.mi/mi-frame-selection.exp > > -- > 2.14.4 >