From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66858 invoked by alias); 22 Aug 2018 17:45:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66781 invoked by uid 89); 22 Aug 2018 17:45:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Aug 2018 17:45:38 +0000 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E79F25D66D for ; Wed, 22 Aug 2018 17:45:35 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-27.phx2.redhat.com [10.3.116.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BFF48308BE72 for ; Wed, 22 Aug 2018 17:45:35 +0000 (UTC) Date: Wed, 22 Aug 2018 17:45:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Make read_program_header return a gdb::byte_vector Message-ID: <20180822104534.17865bb5@pinnacle.lan> In-Reply-To: <20180820012947.10928-1-simon.marchi@polymtl.ca> References: <20180820012947.10928-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00552.txt.bz2 On Sun, 19 Aug 2018 21:29:46 -0400 Simon Marchi wrote: > + optional on failure. If successful and P_ATCH_SIZE is non-NULL, the target I noticed this typo: P_ATCH_SIZE should be P_ARCH_SIZE. Otherwise, LGTM. Kevin