From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80983 invoked by alias); 21 Aug 2018 13:16:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80964 invoked by uid 89); 21 Aug 2018 13:16:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=regset, risk, HContent-Transfer-Encoding:8bit X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Aug 2018 13:16:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B817A116517; Tue, 21 Aug 2018 09:16:48 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id leyDCv4SwqAL; Tue, 21 Aug 2018 09:16:48 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 895EB116417; Tue, 21 Aug 2018 09:16:48 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id BA0D282CB2; Tue, 21 Aug 2018 06:16:46 -0700 (PDT) Date: Tue, 21 Aug 2018 13:16:00 -0000 From: Joel Brobecker To: Alan Hayward Cc: Pedro Alves , GDB Patches , nd Subject: Re: Request for 8.2, SVE cores && adding SVE to NEWS file etc Message-ID: <20180821131646.GB24065@adacore.com> References: <843fee7a-1738-4147-256f-e1fc7950fe18@redhat.com> <3D0DD287-65D9-4D1B-A9EE-67E202B2FF6A@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3D0DD287-65D9-4D1B-A9EE-67E202B2FF6A@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-08/txt/msg00480.txt.bz2 > There’s a simple enough change to the args of a common function. And then everything > else is self contained. I’d break it down into: > > dbd534fee4 5 days ago Alan Hayward Rename size in get_core_register_sectio > - Rename of single variable in common function. Obvious change, no risk. > > a616bb9450 2 days ago Alan Hayward Split size in regset section iterators > - Mechanical change across every tdep file (adds a new third arg, which is a > duplicate of the second arg). Very minor risk on any target that there might > be a copy/paste error that hasn't been spotted (just needs a triple check of > the diff again when merging). Minor risk that I've missed a tdep file that > doesn't get built into a target-all build (causing a build error which I’d > hope would have been spotted by now). > > b7fd65b9dc 2 days ago Alan Hayward Detect SVE when reading aarch64 core files > 0c76e06d5c 2 days ago Alan Hayward Parse SVE registers in aarch64 core file reading/writing > - Limited to reading/writing Aarch64 (SVE and non-SVE) Linux cores on either > a Aarch64 Linux build or target-all build. SVE code is seperated from > standard aarch64 code. So to go wrong on non-SVE, the code would first > have to incorrectly detect the presence of SVE. I took a look at the patches, and I agree they look sufficiently self-contained that they should be OK for inclusion in 8.2. Give Pedro a few days to comment as well, just in case, but otherwise, it is OK for me to backport. -- Joel