Re: [PATCH v4 00/12] GDB support for more powerpc registers on linux

Pedro Franco de Carvalho
2018-08-16T17:42:01Z

Pedro Alves <palves@redhat.com> writes:

> I was reading through the series as you sent this. I sent a couple
> comments to patches #12 and #14. The remarks in #12 is something that can
> always be addressed with this series already merged. Re. the comments for #14,
> it would be nice to go over the series and add missing intro comments to
> functions, etc. Otherwise, it all LGTM. I only really skimmed
> it for mechanics, since as you say Ulrich already reviewed it, and I'm
> far from a Power expert anyway.

Thanks a lot going through these! I will add comments before
commiting.

>> I don't know if a NEWS item counts as obvious, but if not, I can submit
>> it in a separate patch.
>
> It's usually reviewed like other patches. gdb/NEWS falls under
> Eli's documentation maintainership.

Ok, I'll submit it separately so that Eli can have a look at it.

--
Pedro Franco de Carvalho