From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74079 invoked by alias); 10 Aug 2018 14:41:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74068 invoked by uid 89); 10 Aug 2018 14:41:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Aug 2018 14:41:31 +0000 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7AEdnE1060189 for ; Fri, 10 Aug 2018 10:41:30 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ks9yeq4e5-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 10 Aug 2018 10:41:29 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 10 Aug 2018 15:41:26 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 10 Aug 2018 15:41:25 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w7AEfOQM28246194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Aug 2018 14:41:24 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D40D4204B; Fri, 10 Aug 2018 17:41:31 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 42B8E42047; Fri, 10 Aug 2018 17:41:31 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.145.37.152]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 10 Aug 2018 17:41:31 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 46F63D802AC; Fri, 10 Aug 2018 16:41:23 +0200 (CEST) Subject: Re: [PATCH v2 09/12] [PowerPC] Add support for TAR To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho) Date: Fri, 10 Aug 2018 14:41:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, edjunior@gmail.com In-Reply-To: <20180810025210.6942-10-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Aug 09, 2018 11:52:07 PM MIME-Version: 1.0 x-cbid: 18081014-0012-0000-0000-00000297EC7E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18081014-0013-0000-0000-000020CB0087 Message-Id: <20180810144123.46F63D802AC@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-08/txt/msg00278.txt.bz2 Pedro Franco de Carvalho wrote: > gdb/ChangeLog: > YYYY-MM-DD Edjunior Barbosa Machado > Pedro Franco de Carvalho > > * arch/ppc-linux-tdesc.h (tdesc_powerpc_isa207_vsx32l) > (tdesc_powerpc_isa207_vsx64l): Declare. > * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_TARREGSET): Define. > (struct ppc_linux_features) : New field. > (ppc_linux_no_features): Add initializer for isa207 field. > * arch/ppc-linux-common.c (ppc_linux_match_description): Return > new tdescs. > * nat/ppc-linux.h (PPC_FEATURE2_ARCH_2_07, PPC_FEATURE2_TAR) > (NT_PPC_TAR): Define if not already defined. > * features/Makefile (WHICH): Add rs6000/powerpc-isa207-vsx32l and > rs6000/powerpc-isa207-vsx64l. > (XMLTOC): Add rs6000/powerpc-isa207-vsx32l.xml and > rs6000/powerpc-isa207-vsx64l.xml. > * features/rs6000/power-tar.xml: New file. > * features/rs6000/powerpc-isa207-vsx32l.xml: New file. > * features/rs6000/powerpc-isa207-vsx64l.xml: New file. > * features/rs6000/powerpc-isa207-vsx32l.c: Generate. > * features/rs6000/powerpc-isa207-vsx64l.c: Generate. > * regformats/rs6000/powerpc-isa207-vsx32l.dat: Generate. > * regformats/rs6000/powerpc-isa207-vsx64l.dat: Generate. > * ppc-linux-nat.c (fetch_register, fetch_ppc_registers): Call > fetch_regset with the TAR regset. > (store_register, store_ppc_registers): Call store_regset with the > TAR regset. > (ppc_linux_nat_target::read_description): Set isa207 field in the > features struct if needed. > * ppc-linux-tdep.c: Include > features/rs6000/powerpc-isa207-vsx32l.c and > features/rs6000/powerpc-isa207-vsx64l.c. > (ppc32_regmap_tar, ppc32_linux_tarregset): New globals. > (ppc_linux_iterate_over_regset_sections): Call back with the tar > regset. > (ppc_linux_core_read_description): Check if the tar section is > present and set isa207 in the features struct. > (_initialize_ppc_linux_tdep): Call > initialize_tdesc_powerpc_isa207_vsx32l and > initialize_tdesc_powerpc_isa207_vsx64l. > * ppc-linux-tdep.h (ppc32_linux_tarregset): Declare. > * ppc-tdep.h (gdbarch_tdep) : New field. > (enum) : New enum value. > * rs6000-tdep.c (rs6000_gdbarch_init): Look for and validate tar > feature. > (ppc_process_record_op31): Record changes to TAR. > > gdb/gdbserver/ChangeLog: > YYYY-MM-DD Pedro Franco de Carvalho > > * configure.srv (ipa_ppc_linux_regobj): Add > powerpc-isa207-vsx64l-ipa.o and powerpc-isa207-vsx32l-ipa.o. > (powerpc*-*-linux*): Add powerpc-isa207-vsx32l.o and > powerpc-isa207-vsx64l.o to srv_regobj, add rs6000/power-tar.xml, > rs6000/powerpc-isa207-vsx32l.xml, and > rs6000/powerpc-isa207-vsx64l.xml to srv_xmlfiles. > * linux-ppc-tdesc-init.h (enum ppc_linux_tdesc) > : New enum value. > (init_registers_powerpc_isa207_vsx32l): Declare. > (init_registers_powerpc_isa207_vsx64l): Declare. > * linux-ppc-low.c (ppc_fill_tarregset): New function. > (ppc_store_tarregset): New function. > (ppc_regsets): Add entry for the TAR regset. > (ppc_arch_setup): Set isa207 in features struct when needed. Set > size for the TAR regsets. > (ppc_get_ipa_tdesc_idx): Return PPC_TDESC_ISA207_VSX. > (initialize_low_arch): Call init_registers_powerpc_isa207_vsx32l > and init_registers_powerpc_isa207_vsx64l. > * linux-ppc-ipa.c (get_ipa_tdesc): Handle PPC_TDESC_ISA207_VSX. > (initialize_low_tracepoint): Call > init_registers_powerpc_isa207_vsx32l and > init_registers_powerpc_isa207_vsx64l. > > gdb/testsuite/ChangeLog: > YYYY-MM-DD Pedro Franco de Carvalho > > * gdb.arch/powerpc-tar.c: New file. > * gdb.arch/powerpc-tar.exp: New file. > > gdb/doc/ChangeLog: > YYYY-MM-DD Pedro Franco de Carvalho > > * gdb.texinfo (PowerPC Features): Describe new feature > "org.gnu.gdb.power.tar". This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com