Re: [PATCH v2 08/12] [PowerPC] Add support for PPR and DSCR

Pedro Franco de Carvalho
2018-08-10T20:09:41Z

Pedro Alves <palves@redhat.com> writes:

> Skimming the patch I noticed the duplicated test names/messages
> above. Take a look here:
>
> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique
>
> Here I'd use with_test_prefix, something like:
>
> with_test_prefix "something relevant" {
> gdb_test "info reg dscr" "dscr.*0x0*20\[ \t\]+.*"
> gdb_test "info reg ppr" "ppr.*0x0*8000000000000\[ \t\]+.*"
> }
>
> gdb_test "stepi" "asm.*"
>
> with_test_prefix "something else" {
> gdb_test "info reg dscr" "dscr.*0x0*20\[ \t\]+.*"
> gdb_test "info reg ppr" "ppr.*0x0*8000000000000\[ \t\]+.*"
> }

I'll update all the tests. Should I send these in a V3, or as replies to
each patch in this thread?

> BTW, isn't the series NEWS-worthy?

I'll add an item there.

Thanks!

--
Pedro Franco de Carvalho