Re: [PATCH v2 11/12] [PowerPC] Reject tdescs with VSX and no FPU or Altivec

Ulrich Weigand
2018-08-10T14:44:55Z

Pedro Franco de Carvalho wrote:

> Currently rs6000_gdbarch_init will accept a tdesc with the
> "org.gnu.gdb.power.vsx" feature but without the
> "org.gnu.gdb.power.altivec" or "org.gnu.gdb.power.fpu".
>
> It isn't clear from the standard features documentation that these are
> requirements. However, these tdescs would cause trouble in the VSX
> pseudo-register functions, so this patch will cause them to be
> rejected.

Makes sense to me.

> gdb/ChangeLog:
> YYYY-MM-DD Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
>
> * rs6000-tdep.c (rs6000_gdbarch_init): Reject tdescs with vsx but
> without altivec or fpu.

This is OK.

Thanks,
Ulrich

--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com