Re: [PATCH v2 08/12] [PowerPC] Add support for PPR and DSCR

Pedro Alves
2018-08-13T16:30:40Z

On 08/10/2018 09:09 PM, Pedro Franco de Carvalho wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> Skimming the patch I noticed the duplicated test names/messages
>> above. Take a look here:
>>
>> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique
>>
>> Here I'd use with_test_prefix, something like:
>>
>> with_test_prefix "something relevant" {
>> gdb_test "info reg dscr" "dscr.*0x0*20\[ \t\]+.*"
>> gdb_test "info reg ppr" "ppr.*0x0*8000000000000\[ \t\]+.*"
>> }
>>
>> gdb_test "stepi" "asm.*"
>>
>> with_test_prefix "something else" {
>> gdb_test "info reg dscr" "dscr.*0x0*20\[ \t\]+.*"
>> gdb_test "info reg ppr" "ppr.*0x0*8000000000000\[ \t\]+.*"
>> }
>
> I'll update all the tests. Should I send these in a V3, or as replies to
> each patch in this thread?

I usually send a new patch as reply if it's the changes don't affect
the other patches in the series. I.e., if it's not likely to cause confusion
to readers, and is more likely to help readers that way for keeping the
conversation threaded. Otherwise, if you're going to update a
larger set of patches, or if an update to a patch affects other patches
in the series, tend replying to patches with updates is likely to make it
harder to understand and track which pieces go together and thus sending
a new series starting with a clean slate is preferred IMO and is trivial
if you use git send-email.

>
>> BTW, isn't the series NEWS-worthy?
>
> I'll add an item there.

Thanks,
Pedro Alves