Re: [PATCH 1/5] RISC-V: Make riscv_isa_xlen a global function.

Simon Marchi
2018-08-08T19:18:29Z

On 2018-08-07 22:14, Jim Wilson wrote:
> This allows the function to be used from riscv OS files, which also
> need to
> depend on XLEN size.
>
> gdb/
> * riscv-tdep.c (riscv_isa_xlen): Drop static.
> * riscv-tdep.h (riscv_isa_xlen): Add extern declaration.
> ---
> gdb/riscv-tdep.c | 2 +-
> gdb/riscv-tdep.h | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c
> index abcac98016..20181896c5 100644
> --- a/gdb/riscv-tdep.c
> +++ b/gdb/riscv-tdep.c
> @@ -346,7 +346,7 @@ riscv_has_feature (struct gdbarch *gdbarch, char
> feature)
> Possible return values are 4, 8, or 16 for RiscV variants RV32,
> RV64, or
> RV128. */
>
> -static int
> +int
> riscv_isa_xlen (struct gdbarch *gdbarch)
> {
> switch (gdbarch_tdep (gdbarch)->abi.fields.base_len)

Just a note for further patches (you can fix this instance as an obvious
patch if you want): when a function is extern, put the documentation in
the .h, and

/* See riscv-tdep.h. */

in the header file. This way, the two comments won't diverge over time.

Simon