From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52153 invoked by alias); 6 Aug 2018 12:42:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52142 invoked by uid 89); 6 Aug 2018 12:42:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Aug 2018 12:42:46 +0000 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w76CdDKR036121 for ; Mon, 6 Aug 2018 08:42:45 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2kpp4214f8-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 06 Aug 2018 08:42:44 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 Aug 2018 13:42:42 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 6 Aug 2018 13:42:40 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w76CgcTV35192990 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 6 Aug 2018 12:42:38 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 11AEDAE045; Mon, 6 Aug 2018 15:42:34 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 013D2AE051; Mon, 6 Aug 2018 15:42:34 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.80]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 6 Aug 2018 15:42:33 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 913ECD802AF; Mon, 6 Aug 2018 14:42:38 +0200 (CEST) Subject: Re: [PATCH v2 4/6] Use remote register numbers in tracepoint mask To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho) Date: Mon, 06 Aug 2018 12:42:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20180803220948.8910-1-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Aug 03, 2018 07:09:48 PM MIME-Version: 1.0 x-cbid: 18080612-0016-0000-0000-000001F1F111 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18080612-0017-0000-0000-0000324730E6 Message-Id: <20180806124238.913ECD802AF@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-08/txt/msg00084.txt.bz2 Pedro Franco de Carvalho wrote: > If ax_regs_mask and gdbarch_ax_pseudo_register_collect also generate > more ax bytecode, the ax is also appended to the collection list. It > isn't clear that this was the original intent for > gdbarch_ax_pseudo_register_collect, and none of the arches seem to do > this, but if this changes in the future, it should work. OK, this makes sense to me. > * tracepoint.h (class collection_list) : Remove. > : > Declare. > : Add scope parameter. > * tracepoint.c (encode_actions_1): Likewise. > (collection_list::add_register): Rename to ... > (collection_list::add_remote_register): ... this. Update comment. > (collection_list::add_ax_registers, add_local_register): New > methods. > (collection_list::add_memrange): Add scope parameter. Call > add_local_register instead of add_register. > (finalize_tracepoint_aexpr): New function. > (collection_list::collect_symbol): Update calls to add_memrange. > Call add_local_register instead of add_register. Call > add_ax_registers. Call finalize_tracepoint_aexpr. > (encode_actions_1): Get remote regnos for $reg action. Call > add_remote_register, add_ax_registers, and add_local_register. > Update call to add_memrange. Call finalize_tracepoint_aexpr. > (validate_actionline): Call finalize_tracepoint_aexpr. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com