From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50199 invoked by alias); 6 Aug 2018 12:40:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50184 invoked by uid 89); 6 Aug 2018 12:40:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:541, H*x:version, H*UA:version, HContent-Transfer-Encoding:8bit X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Aug 2018 12:40:48 +0000 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w76CcaJ3135883 for ; Mon, 6 Aug 2018 08:40:47 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2kpm97wc6g-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 06 Aug 2018 08:40:47 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 Aug 2018 13:40:45 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 6 Aug 2018 13:40:42 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w76Cefm326214558 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 6 Aug 2018 12:40:41 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 667DF5204E; Mon, 6 Aug 2018 15:40:49 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.80]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 54B6252050; Mon, 6 Aug 2018 15:40:49 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id C7B26D802AF; Mon, 6 Aug 2018 14:40:40 +0200 (CEST) Subject: Re: [PATCH v2 3/6] Use get_remote_packet_size in download_tracepoint To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho) Date: Mon, 06 Aug 2018 12:40:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20180803214124.1033-1-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Aug 03, 2018 06:41:24 PM MIME-Version: 1.0 x-cbid: 18080612-0020-0000-0000-000002B1EE2C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18080612-0021-0000-0000-000020FE2F24 Message-Id: <20180806124040.C7B26D802AF@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-08/txt/msg00083.txt.bz2 Pedro Franco de Carvalho wrote: > * remote.c (remote_target::download_tracepoint): Remove BUF_SIZE. > Replace array buf with gdb::char_vector buf, of size > get_remote_packet_size (). Replace references to buf and BUF_SIZE > to buf.data () and buf.size (). Replace strcpy, strcat and > pack_hex_byte with snprintf. Raise errors if the buffer is too > small. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com