From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101884 invoked by alias); 2 Aug 2018 17:01:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101873 invoked by uid 89); 2 Aug 2018 17:01:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=resize, HContent-Transfer-Encoding:8bit X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Aug 2018 17:01:47 +0000 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w72H1brI132578 for ; Thu, 2 Aug 2018 13:01:46 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2km4w8k39g-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 02 Aug 2018 13:01:40 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 2 Aug 2018 18:00:01 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 2 Aug 2018 18:00:00 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w72GxwAi40042696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 2 Aug 2018 16:59:58 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C0AA252051; Thu, 2 Aug 2018 20:00:08 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.80]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id AD3A35204E; Thu, 2 Aug 2018 20:00:08 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 65955D802AB; Thu, 2 Aug 2018 18:59:58 +0200 (CEST) Subject: Re: [PATCH v2 5/6] Variable size for regs mask in collection list To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho) Date: Thu, 02 Aug 2018 17:01:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20180727210318.2960-6-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Jul 27, 2018 06:03:17 PM MIME-Version: 1.0 x-cbid: 18080217-0008-0000-0000-0000025BD3C2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18080217-0009-0000-0000-000021C2743F Message-Id: <20180802165958.65955D802AB@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-08/txt/msg00040.txt.bz2 Pedro Franco de Carvalho wrote: > * tracepoint.h (collection_list) : Change type to > std::vector. > * tracepoint.c (collection_list::collection_list): Remove > m_regs_mask initializer from initializer list. Resize m_regs_mask > using the largest remote register number. > (collection_list::add_remote_register): Remove size check on > m_regs_mask. Use at to access element. > (collection_list::stringify): Change type of temp_buf to > gdb::char_vector. Update uses of temp_buf. Resize if needed to > stringify the register mask. Use pack_hex_byte for the register > mask. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com