Re: [RFA_v4 4/8] Documents the new commands 'frame apply', faas, taas, tfaas

Philippe Waroquiers
2018-07-11T05:57:57Z

On Wed, 2018-07-11 at 06:06 +0300, Eli Zaretskii wrote:
> > From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> > Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> > Date: Tue, 10 Jul 2018 23:39:22 +0200
> >
> > gdb/doc/ChangeLog
> > 2018-07-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
> >
> > * gdb.texinfo (Debugging Programs with Multiple Threads):
> > Document changes to 'thread apply'. Document 'taas'.
>
> ^^
> Two spaces between sentences, please.
Thanks, fixed.
(I am now running a bunch of grep on git diff to help finding
the above errors, but I need also to grep the commit
messages).

>
> I believe I already approved the rest. Thanks.

Yes, doc/NEWS/on-line help were previously approved on RFA_v2.

Between RFA_v2 and this RFA_v4, some non minor changes were done
e.g. to the new FLAG arguments of 'frame apply' and 'thread apply',
but I saw no explicit re-approval of NEWS and on-line help doc
strings.
(I assume this mail re-approves the doc part RFA_v4, but in any
case a re-review of the code is needed before push of the series).

Thanks

Philippe