From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13015 invoked by alias); 26 Jul 2018 08:33:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12993 invoked by uid 89); 26 Jul 2018 08:33:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.2 spammy=43pm, 43PM, yours X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Jul 2018 08:33:50 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F2E38AE18; Thu, 26 Jul 2018 08:33:47 +0000 (UTC) Date: Thu, 26 Jul 2018 08:33:00 -0000 From: Tom de Vries To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [OB PATCH][gdb/testsuite] Make noclone conditional in vla-optimized-out.c Message-ID: <20180726083405.sjyitxoowte6cx4l@delia> References:<20180720150532.e7dvwtbzyysqwcld@delia> <87sh47yvho.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To:<87sh47yvho.fsf@tromey.com> User-Agent: NeoMutt/20170912 (1.9.0) X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00720.txt.bz2 On Wed, Jul 25, 2018 at 01:18:43PM -0600, Tom Tromey wrote: > >>>>> "Tom" == Tom de Vries writes: > > Tom> Hi, > Tom> Make the noclone attribute on f1 in vla-optimized-out.c conditional. This > Tom> makes the test-case by default identical to > Tom> gcc/testsuite/gcc.dg/guality/vla-1.c. > > Tom> Tested on x86_64-linux. > > Tom> OK for trunk? > > I think this was included in a different patch of yours? Right, in "[gdb/exp] Fix exception when printing optimized out vla". > Anyway, it is ok, thank you. > > It seems like it would be good to mention the GCC file in one of these > files. If you want to add a comment to that effect, it is pre-approved. > Committed as below. Thanks, - Tom 2018-07-26 Tom de Vries * gdb.base/vla-optimized-out.c: Add comment about origin of test-case. [gdb/testsuite] Add comment in gdb.base/vla-optimized-out.c --- gdb/testsuite/gdb.base/vla-optimized-out.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/testsuite/gdb.base/vla-optimized-out.c b/gdb/testsuite/gdb.base/vla-optimized-out.c index ec0a6fdd80..72dfe99d3d 100644 --- a/gdb/testsuite/gdb.base/vla-optimized-out.c +++ b/gdb/testsuite/gdb.base/vla-optimized-out.c @@ -15,6 +15,9 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ +/* The version of this test-case with f1 tagged with noinline only is equivalent + to gcc/testsuite/gcc.dg/guality/vla-1.c. */ + int #ifdef NOCLONE __attribute__((noinline, noclone))