Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFA v2 07/13] Call value_fetch_lazy when needed in pretty-printers
Date: Sat, 21 Jul 2018 18:47:00 -0000	[thread overview]
Message-ID: <20180721184720.3263-8-tom@tromey.com> (raw)
In-Reply-To: <20180721184720.3263-1-tom@tromey.com>

This removes some unused variables, and replaces the calls to
value_contents_for_printing with a call to value_fetch_lazy, when
needed.

gdb/ChangeLog
2018-07-21  Tom Tromey  <tom@tromey.com>

	* python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Remove
	unused variable.  Call value_fetch_lazy when needed.
	* guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
	Remove unused variable.  Call value_fetch_lazy when needed.
---
 gdb/ChangeLog                | 7 +++++++
 gdb/guile/scm-pretty-print.c | 4 +++-
 gdb/python/py-prettyprint.c  | 4 +++-
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/gdb/guile/scm-pretty-print.c b/gdb/guile/scm-pretty-print.c
index 3fe36820a6a..f292960dbbd 100644
--- a/gdb/guile/scm-pretty-print.c
+++ b/gdb/guile/scm-pretty-print.c
@@ -949,7 +949,9 @@ gdbscm_apply_val_pretty_printer (const struct extension_language_defn *extlang,
   enum display_hint hint;
   enum ext_lang_rc result = EXT_LANG_RC_NOP;
   enum string_repr_result print_result;
-  const gdb_byte *valaddr = value_contents_for_printing (val);
+
+  if (value_lazy (val))
+    value_fetch_lazy (val);
 
   /* No pretty-printer support for unavailable values.  */
   if (!value_bytes_available (val, embedded_offset, TYPE_LENGTH (type)))
diff --git a/gdb/python/py-prettyprint.c b/gdb/python/py-prettyprint.c
index 21b1ce94879..a8a84899309 100644
--- a/gdb/python/py-prettyprint.c
+++ b/gdb/python/py-prettyprint.c
@@ -662,7 +662,9 @@ gdbpy_apply_val_pretty_printer (const struct extension_language_defn *extlang,
   struct gdbarch *gdbarch = get_type_arch (type);
   struct value *value;
   enum string_repr_result print_result;
-  const gdb_byte *valaddr = value_contents_for_printing (val);
+
+  if (value_lazy (val))
+    value_fetch_lazy (val);
 
   /* No pretty-printer support for unavailable values.  */
   if (!value_bytes_available (val, embedded_offset, TYPE_LENGTH (type)))
-- 
2.13.6


  parent reply	other threads:[~2018-07-21 18:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-21 18:47 [RFA v2 00/13] Add -Wunused-variable Tom Tromey
2018-07-21 18:47 ` [RFA v2 12/13] Conditionally define xmltarget_${name} variable in regdat.sh Tom Tromey
2018-07-21 18:47 ` [RFA v2 01/13] Simple unused variable removals Tom Tromey
2018-07-22  2:04   ` Simon Marchi
2018-07-21 18:47 ` [RFA v2 04/13] Use a previously unused variable in bfin-tdep.c Tom Tromey
2018-07-21 18:47 ` [RFA v2 06/13] Remove dead code from m32c-tdep.c Tom Tromey
2018-07-22  2:10   ` Simon Marchi
2018-07-21 18:47 ` [RFA v2 02/13] Remove an unused variable from spu_get_overlay_table Tom Tromey
2018-07-22  2:06   ` Simon Marchi
2018-07-22 18:59     ` Ulrich Weigand
2018-07-21 18:47 ` [RFA v2 05/13] Call some functions in guile/ for effect Tom Tromey
2018-07-21 18:47 ` Tom Tromey [this message]
2018-07-21 18:47 ` [RFA v2 09/13] Pass the correct argument to the observer in reread_symbols Tom Tromey
2018-07-21 18:47 ` [RFA v2 10/13] Remove unused declaration from value.c Tom Tromey
2018-07-22  2:13   ` Simon Marchi
2018-07-21 18:47 ` [RFA v2 11/13] Remove unused variables from gdbserver Tom Tromey
2018-07-21 18:47 ` [RFA v2 08/13] Fix ravenscar-thread.c to use arch_ops Tom Tromey
2018-07-21 18:47 ` [RFA v2 03/13] Unused variable fixes related to conditional compilation Tom Tromey
2018-07-21 18:47 ` [RFA v2 13/13] Add -Wunused-variable to warnings.m4 Tom Tromey
2018-07-22  2:26 ` [RFA v2 00/13] Add -Wunused-variable Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180721184720.3263-8-tom@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox