From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19734 invoked by alias); 21 Jul 2018 18:47:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19601 invoked by uid 89); 21 Jul 2018 18:47:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=scm, SCM, Hx-languages-length:1760 X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.58.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 21 Jul 2018 18:47:24 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway20.websitewelcome.com (Postfix) with ESMTP id AC89D400D0575 for ; Sat, 21 Jul 2018 13:47:23 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gwuZftQd9bXuJgwuZf0clt; Sat, 21 Jul 2018 13:47:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2oPdA19JYOFF7NBHCghJsV5/YWH3msDXOJ0T2nz5uew=; b=WD3LZpq2bzfFVjibLzu3CTVby/ M4iWZqTOMK+je6I6SDMy7hKG2aJmxPjQtLg91xoRPyL0vaAuiFK4zhODBp+0eM/S0tBGwO5imVFJV C91bWFNz15ssPVTwiTRpHJf+0; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:44394 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fgwuZ-002Auc-FZ; Sat, 21 Jul 2018 13:47:23 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA v2 05/13] Call some functions in guile/ for effect Date: Sat, 21 Jul 2018 18:47:00 -0000 Message-Id: <20180721184720.3263-6-tom@tromey.com> In-Reply-To: <20180721184720.3263-1-tom@tromey.com> References: <20180721184720.3263-1-tom@tromey.com> X-SW-Source: 2018-07/txt/msg00633.txt.bz2 This changes a couple of spots in guile/ to remove a variable declaration but to still call a function for effect. gdb/ChangeLog 2018-07-21 Tom Tromey * guile/scm-cmd.c (gdbscm_dont_repeat): Call cmdscm_get_valid_command_smob_arg_unsafe for effect. * guile/scm-block.c (gdbscm_make_block_syms_iter): Call bkscm_get_valid_block_smob_arg_unsafe for effect. --- gdb/ChangeLog | 7 +++++++ gdb/guile/scm-block.c | 5 ++--- gdb/guile/scm-cmd.c | 6 +++--- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/gdb/guile/scm-block.c b/gdb/guile/scm-block.c index d4566fc1ffe..9caff799dc1 100644 --- a/gdb/guile/scm-block.c +++ b/gdb/guile/scm-block.c @@ -613,9 +613,8 @@ bkscm_block_syms_progress_p (SCM scm) static SCM gdbscm_make_block_syms_iter (SCM self) { - block_smob *b_smob - = bkscm_get_valid_block_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME); - const struct block *block = b_smob->block; + /* Call for side effects. */ + bkscm_get_valid_block_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME); SCM progress, iter; progress = bkscm_make_block_syms_progress_smob (); diff --git a/gdb/guile/scm-cmd.c b/gdb/guile/scm-cmd.c index 88a98643a91..4291933e40e 100644 --- a/gdb/guile/scm-cmd.c +++ b/gdb/guile/scm-cmd.c @@ -267,9 +267,9 @@ gdbscm_command_valid_p (SCM self) static SCM gdbscm_dont_repeat (SCM self) { - /* We currently don't need anything from SELF, but still verify it. */ - command_smob *c_smob - = cmdscm_get_valid_command_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME); + /* We currently don't need anything from SELF, but still verify it. + Call for side effects. */ + cmdscm_get_valid_command_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME); dont_repeat (); -- 2.13.6