From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19995 invoked by alias); 21 Jul 2018 18:47:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19640 invoked by uid 89); 21 Jul 2018 18:47:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=route, symfile.c, UD:symfile.c, reread_symbols X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 21 Jul 2018 18:47:26 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id D1B911C06 for ; Sat, 21 Jul 2018 13:47:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gwuaf4qKrBcCXgwuafjTBc; Sat, 21 Jul 2018 13:47:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CUIldAB0nvdbsqjHCo1yX1h5hs3XDy2TnKv0tljJ0PI=; b=hXtwv7exB4nUVGr4QmN7PRxyug efRovDiLITJaCLW2Me0ZWu2CSi8UZnqhWtTIb6/dHSQ7EF0sVDd1kKuB6fTbnSEd7boFY1MC27zLm tXCBwc5XKgLCS9ctBd2aYTpy/; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:44394 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fgwua-002Auc-LR; Sat, 21 Jul 2018 13:47:24 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA v2 09/13] Pass the correct argument to the observer in reread_symbols Date: Sat, 21 Jul 2018 18:47:00 -0000 Message-Id: <20180721184720.3263-10-tom@tromey.com> In-Reply-To: <20180721184720.3263-1-tom@tromey.com> References: <20180721184720.3263-1-tom@tromey.com> X-SW-Source: 2018-07/txt/msg00638.txt.bz2 This is actually a patch I found via another route. Joel had asked me to write a test, but I still have not found the time to do this. Meanwhile, -Wunused-variable also found this error. gdb/ChangeLog 2018-07-21 Tom Tromey * symfile.c (reread_symbols): Notify iter, not objfile. --- gdb/ChangeLog | 4 ++++ gdb/symfile.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/symfile.c b/gdb/symfile.c index 3614aa3f955..20697d9dca2 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -2608,7 +2608,7 @@ reread_symbols (void) gdb::observers::new_objfile.notify (NULL) has been called by clear_symtab_users above. Notify the new files now. */ for (auto iter : new_objfiles) - gdb::observers::new_objfile.notify (objfile); + gdb::observers::new_objfile.notify (iter); /* At least one objfile has changed, so we can consider that the executable we're debugging has changed too. */ -- 2.13.6