Re: [RFC] mi: add -a option to the "-data-disassemble" command

Eli Zaretskii
2018-07-26T17:47:28Z

> From: Jan Vrany <jan.vrany@fit.cvut.cz>
> Cc: Jan Vrany <jan.vrany@fit.cvut.cz>
> Date: Thu, 26 Jul 2018 15:55:57 +0100
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 839466e7e0..3367be4375 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,9 @@
>
> *** Changes since GDB 8.1
>
> +* The '-data-disassemble' MI command now accepts an '-a' option to disassemble
^^^^^^^^^^^^^^
"the '-a' option"

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 7fb6ac5636..af2a0948c3 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -30947,6 +30947,7 @@ For details about what an addressable memory unit is,
> @smallexample
> -data-disassemble
> [ -s @var{start-addr} -e @var{end-addr} ]
> + | [ -a @var{addr} ]
> | [ -f @var{filename} -l @var{linenum} [ -n @var{lines} ] ]
> -- @var{mode}
> @end smallexample
> @@ -30959,6 +30960,11 @@ Where:
> is the beginning address (or @code{$pc})
> @item @var{end-addr}
> is the end address
> +@item @var{addr}
> +is the address anywhere in function code (or function name). If @var{addr}
> +is specified, the whole function surrounding that address will be disassembled.
> +If @var{addr} is a function name, the whole function with that name will be
> +disassembled.

You never mention the -a option in the text. I think you should.

Thanks.