Re: [RFC] mi: add -a option to the "-data-disassemble" command

Tom Tromey
2018-08-09T20:47:28Z

>>>>> "Jan" == Jan Vrany <jan.vrany@fit.cvut.cz> writes:

Jan> A CLI command "disassemble" allows use to specify a single
Jan> address - in that case function surrounding that address is
Jan> disassembled.

Hi, I didn't see this go in and I thought maybe it needed a new reply?

Jan> - if (!((line_seen && file_seen && num_seen && !start_seen && !end_seen)
Jan> - || (line_seen && file_seen && !num_seen && !start_seen && !end_seen)
Jan> - || (!line_seen && !file_seen && !num_seen && start_seen && end_seen)))
Jan> + if (!( ( line_seen && file_seen && !start_seen && !end_seen && !addr_seen)
Jan> + || (!line_seen && !file_seen && !num_seen && start_seen && end_seen && !addr_seen)
Jan> + || (!line_seen && !file_seen && !num_seen && !start_seen && !end_seen && addr_seen)))

These go over 80 columns now, so I think they need to be reformatted
somehow to fit. Please use your judgment, what you did here is already
better than the status quo...

No need to re-post the patch, you can just put it in with the
correction. Thank you.

Tom