From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86963 invoked by alias); 13 Jul 2018 16:40:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86947 invoked by uid 89); 13 Jul 2018 16:40:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jul 2018 16:40:32 +0000 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6DGdPJD145245 for ; Fri, 13 Jul 2018 12:40:30 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2k6ynvgbq3-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Jul 2018 12:40:30 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Jul 2018 17:40:26 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 13 Jul 2018 17:40:24 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6DGeNur39977024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 13 Jul 2018 16:40:23 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A96F42047; Fri, 13 Jul 2018 19:40:44 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 05F7C4204D; Fri, 13 Jul 2018 19:40:44 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.167.239.119]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 13 Jul 2018 19:40:43 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 7163BD80276; Fri, 13 Jul 2018 18:40:22 +0200 (CEST) Subject: Re: [PATCH 17/17] [PowerPC] Add gdbserver support for EBB and PMU registers To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho) Date: Fri, 13 Jul 2018 16:40:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, edjunior@gmail.com In-Reply-To: <20180713135226.2321-18-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Jul 13, 2018 10:52:26 AM MIME-Version: 1.0 x-cbid: 18071316-4275-0000-0000-00000298BD64 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18071316-4276-0000-0000-000037A0C6A4 Message-Id: <20180713164022.7163BD80276@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-07/txt/msg00421.txt.bz2 Pedro Franco de Carvalho wrote: > +ppc_store_ebbregset (struct regcache *regcache, const void *buf) > +{ > + int base; > + char *regset = (char *) buf; > + > + base = find_regno (regcache->tdesc, "bescr"); > + > + /* The order in the kernel regset is: EBBRR, EBBHR, BESCR, in our > + .dat file it is BESCR, EBBHR, EBBRR. */ > + supply_register (regcache, base, ®set[16]); > + supply_register (regcache, base + 1, ®set[8]); > + supply_register (regcache, base + 2, ®set[0]); Why do this? Can't we recorder the XML file to make the order the same, and simplify this routine? > + /* The order in the kernel regset is SIAR, SDAR, SIER, MMCR2, MMCR0. > + In the .dat file is MMCR0, MMCR2, SIAR, SDAR, SIER. */ > + supply_register (regcache, base, ®set[32]); > + supply_register (regcache, base + 1, ®set[24]); > + supply_register (regcache, base + 2, ®set[0]); > + supply_register (regcache, base + 3, ®set[8]); > + supply_register (regcache, base + 4, ®set[16]); Same here? Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com