From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69480 invoked by alias); 13 Jul 2018 16:26:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69469 invoked by uid 89); 13 Jul 2018 16:26:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,UNSUBSCRIBE_BODY autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jul 2018 16:26:16 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6DGNoAG173235 for ; Fri, 13 Jul 2018 12:26:15 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2k6vpy0568-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Jul 2018 12:26:15 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Jul 2018 17:26:13 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 13 Jul 2018 17:26:11 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6DGQA3T35258448 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 13 Jul 2018 16:26:10 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 82861AE055; Fri, 13 Jul 2018 19:26:02 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6D6BEAE051; Fri, 13 Jul 2018 19:26:02 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.167.239.119]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 13 Jul 2018 19:26:02 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id CB0C9D80276; Fri, 13 Jul 2018 18:26:09 +0200 (CEST) Subject: Re: [PATCH 14/17] [PowerPC] Add gdbserver support for HTM registers To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho) Date: Fri, 13 Jul 2018 16:26:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, edjunior@gmail.com In-Reply-To: <20180713135226.2321-15-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Jul 13, 2018 10:52:23 AM MIME-Version: 1.0 x-cbid: 18071316-0008-0000-0000-00000252D790 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18071316-0009-0000-0000-000021B91717 Message-Id: <20180713162609.CB0C9D80276@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-07/txt/msg00418.txt.bz2 Pedro Franco de Carvalho wrote: > The "fill" functions for checkpointed register sets are not > implemented, because ptrace can return ENODATA for these regsets > whenever the inferior is not in a transaction. > > Since gdbserver writes all registers in one go before resuming the > inferior, this error would not be detected at the time the user tries > to write to one of the registers on the client side, and gdbserver > would print out warnings every time it resumes the inferior when it is > not in a transaction, so there is currently no straightforward way to > handle this case. This means the checkpointed registers in the > client-side regcache can become dirty when the user tries to write to > them, until the inferior is resumed and stopped again. > > Another limitation for the checkpointed registers is that traceframes > don't record if registers are available or not, so if these registers > are collected when a tracepoint is hit and the inferior is not in a > transaction, the user will see zero values for all of them, instead of > the usual . Hmm. It's a bit unfortunate to have these differences between native and gdbserver debugging. But I guess this is unavoidable for now. > gdb/gdbserver/ChangeLog: > 2018-07-05 Pedro Franco de Carvalho > > * linux-ppc-tdesc-init.h (enum ppc_linux_tdesc) > : New enum value. > (init_registers_powerpc_isa207_htm_vsx32l) > (init_registers_powerpc_isa207_htm_vsx64l): Declare. > * linux-ppc-low.c (ppc_fill_tm_sprregset, ppc_store_tm_sprregset) > (ppc_store_tm_cgprregset, ppc_store_tm_cfprregset) > (ppc_store_tm_cvrregset, ppc_store_tm_cvsxregset) > (ppc_store_tm_cpprregset, ppc_store_tm_cdscrregset) > (ppc_store_tm_ctarregset): New functions. > (ppc_regsets): Add entries for HTM regsets. > (ppc_arch_setup): Set htm in features struct when needed. Set > sizes for the HTM regsets. > (ppc_get_ipa_tdesc_idx): Return PPC_TDESC_ISA207_HTM_VSX. > (initialize_low_arch): Call > init_registers_powerpc_isa207_htm_vsx32l and > init_registers_powerpc_isa207_htm_vsx64l. > * linux-ppc-ipa.c (get_ipa_tdesc): Handle > PPC_TDESC_ISA207_HTM_VSX. > (initialize_low_tracepoint): Call > init_registers_powerpc_isa207_htm_vsx32l and > init_registers_powerpc_isa207_htm_vsx64l. This is OK once base support is in. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com