From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54092 invoked by alias); 13 Jul 2018 15:25:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53968 invoked by uid 89); 13 Jul 2018 15:25:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jul 2018 15:25:06 +0000 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6DFKGJt039071 for ; Fri, 13 Jul 2018 11:25:05 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2k6v58q70y-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Jul 2018 11:25:04 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Jul 2018 16:25:03 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 13 Jul 2018 16:25:00 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6DFOxEt19595456 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 13 Jul 2018 15:24:59 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 33BFB42041; Fri, 13 Jul 2018 18:25:20 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1EB5F42045; Fri, 13 Jul 2018 18:25:20 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.167.239.119]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 13 Jul 2018 18:25:20 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 8CCEDD80276; Fri, 13 Jul 2018 17:24:58 +0200 (CEST) Subject: Re: [PATCH 06/17] [PowerPC] Add record/replay support for PPR and DSCR To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho) Date: Fri, 13 Jul 2018 15:25:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, edjunior@gmail.com In-Reply-To: <20180713135226.2321-7-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Jul 13, 2018 10:52:15 AM MIME-Version: 1.0 x-cbid: 18071315-0016-0000-0000-000001E68707 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18071315-0017-0000-0000-0000323B2417 Message-Id: <20180713152458.8CCEDD80276@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-07/txt/msg00408.txt.bz2 Pedro Franco de Carvalho wrote: > gdb/ChangeLog: > YYYY-MM-DD Pedro Franco de Carvalho > > * rs6000-tdep.c (ppc_process_record_op31): Record changes to PPR > and DSCR. > case 476: /* NAND */ > case 412: /* OR with Complement */ > case 444: /* OR */ > + /* Or Rx,Rx,Rx alters PRI in PPR. */ > + if (tdep->ppc_ppr_regnum >= 0 > + && (PPC_RS (insn) == PPC_RA (insn)) > + && (PPC_RA (insn) == PPC_RB (insn)) > + && !PPC_RC (insn)) > + { > + record_full_arch_list_add_reg (regcache, tdep->ppc_ppr_regnum); > + return 0; > + } This should be done *only* for OR, not for any of the others that fall through to the above code ... Otherwise, this is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com