From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109265 invoked by alias); 13 Jul 2018 15:17:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109253 invoked by uid 89); 13 Jul 2018 15:17:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jul 2018 15:17:01 +0000 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6DFEUlQ023097 for ; Fri, 13 Jul 2018 11:17:00 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2k6v58pw83-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Jul 2018 11:16:59 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Jul 2018 16:16:58 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 13 Jul 2018 16:16:56 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6DFGt6N39649504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 13 Jul 2018 15:16:55 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C37BE52057; Fri, 13 Jul 2018 18:17:15 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.167.239.119]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id AF6F55204E; Fri, 13 Jul 2018 18:17:15 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 7A7B3D80276; Fri, 13 Jul 2018 17:16:54 +0200 (CEST) Subject: Re: [PATCH 01/17] [PowerPC] Simplify rs6000_pseudo_register_reggroup_p To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho) Date: Fri, 13 Jul 2018 15:17:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, edjunior@gmail.com In-Reply-To: <20180713135226.2321-2-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Jul 13, 2018 10:52:10 AM MIME-Version: 1.0 x-cbid: 18071315-0008-0000-0000-00000252D250 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18071315-0009-0000-0000-000021B9119D Message-Id: <20180713151654.7A7B3D80276@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-07/txt/msg00403.txt.bz2 Pedro Franco de Carvalho wrote: > Group membership for SPE, VSX and EFP pseudoregisters can be detected > through their types in default_register_reggroup_p. DFP pseudoregs > still need special handling when checking membership to the float > group, because default_register_reggroup_p doesn't consider registers > with type code TYPE_CODE_DECFLOAT to be part of the float group. > > gdb/ChangeLog: > YYYY-MM-DD Pedro Franco de Carvalho > > * rs6000-tdep.c (rs6000_pseudo_register_reggroup_p): Call > default_register_reggroup_p. This is OK with me, but it might actually be even better to change default_register_reggroup_p to consider TYPE_CODE_DECFLOAT registers to be part o the float group as well. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com