From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56085 invoked by alias); 12 Jul 2018 20:52:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55922 invoked by uid 89); 12 Jul 2018 20:52:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=avoided, Hx-languages-length:559 X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.48.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jul 2018 20:52:30 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 5023C13E46 for ; Thu, 12 Jul 2018 15:52:29 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id diZOfRGTfaSeydiZYf4Dwi; Thu, 12 Jul 2018 15:52:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:MIME-Version :Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vkjTCdlXCfPmrIZe1MZykNYsbwxEXw8FEdsg+1eaWgI=; b=s5bbfwbUMt0KE/dJ2E17Gdbm/E WCus0E1TsqEEJSNpxHrI8546KAWZ9I6scRalJnlPYWWPAEK2Q1L5EwqyilafglvH+nXZLZEatyo5v KlPWGZGuSN2qpwD27v56yIeTE; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:49432 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fdiZO-001ZuD-Kr for gdb-patches@sourceware.org; Thu, 12 Jul 2018 15:52:10 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [RFA 00/13] Add -Wunused-variable Date: Thu, 12 Jul 2018 20:52:00 -0000 Message-Id: <20180712205208.32646-1-tom@tromey.com> X-SW-Source: 2018-07/txt/msg00362.txt.bz2 An earlier thread pointed out the desirability of -Wunused-variable. This series adds this to the build. In a couple of spots I found it expedient to use ATTRIBUTE_UNUSED, but mostly I avoided this. I also examined the other existing uses of ATTRIBUTE_UNUSED to make sure they seemed ok. They did to me. This series would not have been possible without Simon, who reduce the needed configure test to a manageable size. -Wunused-variable caught a couple real bugs. See patch #8 and patch #9. Tested by the buildbot. Tom